-
Notifications
You must be signed in to change notification settings - Fork 291
feat(cards): add card counters #6511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
@@ -358,6 +365,13 @@ export default { | |||
this.setPageTitle(current.title) | |||
} | |||
}, | |||
stacksByBoard: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this watch is not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain why this watcher is necessary even though the cardsCount
is a computed variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Ronni Dal Lago <[email protected]>
Signed-off-by: Ronni Dal Lago <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.1.0 to 4.3.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4.1.0...v4.3.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.2.4 to 3.2.5. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.2.4...3.2.5) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.2.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Julius Knorr <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Bumps [@nextcloud/webpack-vue-config](https://github.com/nextcloud-libraries/webpack-vue-config) from 6.2.0 to 6.3.0. - [Release notes](https://github.com/nextcloud-libraries/webpack-vue-config/releases) - [Changelog](https://github.com/nextcloud-libraries/webpack-vue-config/blob/main/CHANGELOG.md) - [Commits](nextcloud-libraries/webpack-vue-config@v6.2.0...v6.3.0) --- updated-dependencies: - dependency-name: "@nextcloud/webpack-vue-config" dependency-version: 6.3.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [nextcloud-libraries/npm-audit-action](https://github.com/nextcloud-libraries/npm-audit-action) from 0.1.0 to 0.2.0. - [Release notes](https://github.com/nextcloud-libraries/npm-audit-action/releases) - [Commits](nextcloud-libraries/npm-audit-action@2a60bd2...1b1728b) --- updated-dependencies: - dependency-name: nextcloud-libraries/npm-audit-action dependency-version: 0.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@nextcloud/vue](https://github.com/nextcloud-libraries/nextcloud-vue) from 8.24.0 to 8.25.1. - [Release notes](https://github.com/nextcloud-libraries/nextcloud-vue/releases) - [Changelog](https://github.com/nextcloud-libraries/nextcloud-vue/blob/v8.25.1/CHANGELOG.md) - [Commits](nextcloud-libraries/nextcloud-vue@v8.24.0...v8.25.1) --- updated-dependencies: - dependency-name: "@nextcloud/vue" dependency-version: 8.25.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.3.0 to 4.4.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4.3.0...v4.4.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: grnd-alt <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Julius Knorr <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Knorr <[email protected]>
Signed-off-by: Julius Knorr <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Richard Steinmetz <[email protected]>
Signed-off-by: Luka Trovic <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Updates the requirements on [behat/behat](https://github.com/Behat/Behat) to permit the latest version. - [Release notes](https://github.com/Behat/Behat/releases) - [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md) - [Commits](Behat/Behat@v3.18.1...v3.21.1) --- updated-dependencies: - dependency-name: behat/behat dependency-version: 3.21.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [shivammathur/setup-php](https://github.com/shivammathur/setup-php) from 2.32.0 to 2.33.0. - [Release notes](https://github.com/shivammathur/setup-php/releases) - [Commits](shivammathur/setup-php@2.32.0...2.33.0) --- updated-dependencies: - dependency-name: shivammathur/setup-php dependency-version: 2.33.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.26.10 to 7.27.0. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.27.0/packages/babel-runtime) --- updated-dependencies: - dependency-name: "@babel/runtime" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Bumps [@relative-ci/agent](https://github.com/relative-ci/agent) from 4.2.14 to 4.3.1. - [Release notes](https://github.com/relative-ci/agent/releases) - [Commits](relative-ci/agent@v4.2.14...v4.3.1) --- updated-dependencies: - dependency-name: "@relative-ci/agent" dependency-version: 4.3.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Summary
Add card counters to each stack
TODO
Checklist