Skip to content

Fix small issues around delete/undo - #5296

Merged
juliusknorr merged 3 commits into
mainfrom
bugfix/noid/deleted-board-frontend
Nov 20, 2023
Merged

Fix small issues around delete/undo#5296
juliusknorr merged 3 commits into
mainfrom
bugfix/noid/deleted-board-frontend

Conversation

@juliusknorr

@juliusknorr juliusknorr commented Nov 17, 2023

Copy link
Copy Markdown
Member
  • fix: Only query boards not marked for deletion unless we want to undo
  • fix: Show proper error page when board was not found
  • fix: Properly undo card deletion in the frontend

@juliusknorr juliusknorr changed the title bugfix/noid/deleted board frontend Fix small issues around delete/undo Nov 17, 2023
@juliusknorr juliusknorr added this to the 1.11.0 (Nextcloud 28) milestone Nov 17, 2023
@juliusknorr
juliusknorr force-pushed the bugfix/noid/deleted-board-frontend branch from ba42da7 to 6c18f50 Compare November 17, 2023 10:38
Comment thread src/components/board/Board.vue Outdated
<div class="board-wrapper">
<Controls :board="board" />

{{ loading }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it redundant?

Comment thread lib/Service/CardService.php Outdated
if ($card->getDeletedAt() !== 0) {
if ($deletedAt === null) {
// Only allow operations when restoring the card
throw new StatusException('Operation not allowed.');

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be better: Operation not allowed. This card was deleted.

Signed-off-by: Julius H盲rtl <jus@bitgrid.net>
Signed-off-by: Julius H盲rtl <jus@bitgrid.net>
Signed-off-by: Julius H盲rtl <jus@bitgrid.net>
@juliusknorr
juliusknorr force-pushed the bugfix/noid/deleted-board-frontend branch from 6c18f50 to 3c047d3 Compare November 20, 2023 07:22
@juliusknorr
juliusknorr merged commit ebdbe65 into main Nov 20, 2023
@juliusknorr
juliusknorr deleted the bugfix/noid/deleted-board-frontend branch November 20, 2023 14:30
@juliusknorr

Copy link
Copy Markdown
Member Author

/backport to stable27

@juliusknorr

Copy link
Copy Markdown
Member Author

/backport to stable26

@juliusknorr

Copy link
Copy Markdown
Member Author

/backport to stable27

@juliusknorr

Copy link
Copy Markdown
Member Author

/backport to stable26

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@juliusknorr

Copy link
Copy Markdown
Member Author

/backport a05d642 to stable26

@juliusknorr

Copy link
Copy Markdown
Member Author

/backport a05d642 to stable25

@juliusknorr

Copy link
Copy Markdown
Member Author

/backport a05d642 to stable24

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@juliusknorr

Copy link
Copy Markdown
Member Author

/backport a05d642 to stable23

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable24 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable24
git pull origin stable24

# Create the new backport branch
git checkout -b fix/foo-stable24

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable24

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable23 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable23
git pull origin stable23

# Create the new backport branch
git checkout -b fix/foo-stable23

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable23

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants