Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine bday and deathdate #4377

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

GVodyanov
Copy link
Contributor

@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Mar 7, 2025
@GVodyanov GVodyanov self-assigned this Mar 7, 2025
@GVodyanov GVodyanov requested a review from hamza221 as a code owner March 7, 2025 17:33
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 11.11%. Comparing base (9d71828) to head (1f101f7).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/components/ContactDetails.vue 0.00% 10 Missing ⚠️
src/components/Properties/PropertyTitle.vue 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4377      +/-   ##
============================================
- Coverage     11.14%   11.11%   -0.03%     
  Complexity      265      265              
============================================
  Files           122      122              
  Lines          5537     5551      +14     
  Branches       1187     1193       +6     
============================================
  Hits            617      617              
- Misses         4799     4813      +14     
  Partials        121      121              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@provokateurin
Copy link
Member

The category is still named birthday which doesn't seem appropriate (especially if the contact only has a date of death set), but I don't know a user friendly wording for "life events".

@GVodyanov
Copy link
Contributor Author

I mean... is "life events" really that bad? I can't think of anything much better, maybe "personal dates"?

@provokateurin
Copy link
Member

"Personal dates" sounds good to me, especially if there are other standardized fields for dates in contacts (e.g. marriage maybe?).

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but didn't test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants