-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine bday and deathdate #4377
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Grigory V <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4377 +/- ##
============================================
- Coverage 11.14% 11.11% -0.03%
Complexity 265 265
============================================
Files 122 122
Lines 5537 5551 +14
Branches 1187 1193 +6
============================================
Hits 617 617
- Misses 4799 4813 +14
Partials 121 121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The category is still named birthday which doesn't seem appropriate (especially if the contact only has a date of death set), but I don't know a user friendly wording for "life events". |
I mean... is "life events" really that bad? I can't think of anything much better, maybe "personal dates"? |
"Personal dates" sounds good to me, especially if there are other standardized fields for dates in contacts (e.g. marriage maybe?). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but didn't test
#4181