Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve contact view accessibility #4368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SebastianKrupinski
Copy link
Contributor

Resolves: #4366

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 11.13%. Comparing base (44f4c7b) to head (d8c74af).

Files with missing lines Patch % Lines
src/components/Properties/PropertyMultipleText.vue 0.00% 1 Missing ⚠️
src/components/Properties/PropertyRev.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4368   +/-   ##
=========================================
  Coverage     11.13%   11.13%           
  Complexity      265      265           
=========================================
  Files           122      122           
  Lines          5541     5541           
  Branches       1185     1185           
=========================================
  Hits            617      617           
- Misses         4802     4803    +1     
+ Partials        122      121    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -98,10 +98,10 @@
<template v-else>
<div v-for="(value, index) in filteredValue"
:key="index"
class="property__row">
class="property__row" rolw="rowgroup">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
Status: 🏗️ In progress
Development

Successfully merging this pull request may close these issues.

Accessibility: Form fields for contact data have no label elements
2 participants