-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove quotes on import #3243
remove quotes on import #3243
Conversation
to comply with https://www.rfc-editor.org/rfc/rfc6350#section-5 Signed-off-by: Stefan Mielke <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3243 +/- ##
==========================================
+ Coverage 1.91% 2.23% +0.31%
==========================================
Files 112 87 -25
Lines 5801 4977 -824
Branches 1345 1345
==========================================
Hits 111 111
+ Misses 5576 4752 -824
Partials 114 114 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works.
Rebase is not necessary as frontend tests are passing and still up to date. |
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
/backport to stable5.2 |
to comply with https://www.rfc-editor.org/rfc/rfc6350#section-5
see also #2866