Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove quotes on import #3243

Merged
merged 1 commit into from
Mar 6, 2023
Merged

remove quotes on import #3243

merged 1 commit into from
Mar 6, 2023

Conversation

caplod
Copy link
Contributor

@caplod caplod commented Feb 23, 2023

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.31 🎉

Comparison is base (3659d86) 1.91% compared to head (c04307a) 2.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##              main   #3243      +/-   ##
==========================================
+ Coverage     1.91%   2.23%   +0.31%     
==========================================
  Files          112      87      -25     
  Lines         5801    4977     -824     
  Branches      1345    1345              
==========================================
  Hits           111     111              
+ Misses        5576    4752     -824     
  Partials       114     114              
Impacted Files Coverage Δ
src/store/addressbooks.js 2.89% <0.00%> (ø)
composer/autoload.php
lib/Listener/LoadContactsFilesActions.php
.php-cs-fixer.dist.php
lib/Service/Social/XingProvider.php
lib/Service/Social/DiasporaProvider.php
lib/Service/Social/CompositeSocialProvider.php
lib/Service/Social/TumblrProvider.php
lib/AppInfo/Application.php
lib/Service/Social/GravatarProvider.php
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristophWurst ChristophWurst added bug Something isn't working compatibility Compatibility with other services feature: contacts 3. to review Waiting for reviews labels Mar 6, 2023
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny
Copy link
Member

st3iny commented Mar 6, 2023

Rebase is not necessary as frontend tests are passing and still up to date.

@st3iny st3iny merged commit f676e7b into nextcloud:main Mar 6, 2023
@welcome
Copy link

welcome bot commented Mar 6, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@st3iny st3iny modified the milestones: v5.2.0, v5.3.0 Mar 6, 2023
@st3iny
Copy link
Member

st3iny commented Mar 6, 2023

/backport to stable5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug Something isn't working compatibility Compatibility with other services feature: contacts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants