Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Email Address not cleaned/validated #4379

Open
2 of 6 tasks
timedin-de opened this issue Mar 11, 2025 · 0 comments · May be fixed by #4380 or nextcloud/server#51478
Open
2 of 6 tasks

Contact Email Address not cleaned/validated #4379

timedin-de opened this issue Mar 11, 2025 · 0 comments · May be fixed by #4380 or nextcloud/server#51478
Labels

Comments

@timedin-de
Copy link

timedin-de commented Mar 11, 2025

Describe the bug

Email Entry is not cleaned on save, when email-adresses are invalid mail delivery fails as unknown error.

The validation could also apply to phone number, address... but i think email is the most critical, because of the automatic nextcloud messages.

This seems like missing a common feature? Is this on purpose or was just never a reason to implement.

I recently had a problem where it would send calender invites for contacts bc. they contained spaces and i could find the problem at first.

Steps to reproduce

  1. Go to new or existing contact
  2. Set email entry to invalid address (spaces, no @, no tld...)
  3. Save
  4. Cause Email-Send Action (calender invitation, ...)

Expected behavior

It should'nt be possible to have contacts with invalid email-adresses.

  • Trimming spaces out of email (if some format accidently adds it)
  • Validating and rejecting invalid email-adresses on edit
    • In WebUi
    • On File-Import
    • On CardDav Sync
    • ?Provide way to fix current entrys?

Actual behavior

You can easily add invalid email addresses to contacts and nextcloud tries to send emails to them but fails as unknown.

Contact version

7.0.3

Operating system

No response

PHP engine version

PHP 8.3

Web server

Apache (supported)

Database

MariaDB

Additional info

The profile editor already has a validation system, so can be copied.
Phone Number and Address Validation may be nice, but probably cause problems bc. of different typing, and are not critical, as nextcloud does not use them.

@timedin-de timedin-de linked a pull request Mar 12, 2025 that will close this issue
5 tasks
@timedin-de timedin-de changed the title Email Adress not cleaned/validated (REGEX) Email Address not cleaned/validated (REGEX) Mar 12, 2025
@timedin-de timedin-de changed the title Email Address not cleaned/validated (REGEX) Contact Email Address not cleaned/validated Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant