fix(occ): handle share wrappers that do not have a circle #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
fix/occ-share-files-without-circle
branch
from
5b7baa4 to
c22aac2
Compare
max-nextcloud
commented
Feb 11, 2025
| @@ -203,15 +203,20 @@ private function displayShares( | |||
| $sharedTo .= '@' . $recipient->getInstance(); | |||
| } | |||
| } | |||
| $circle = $share->getCircle(); | |||
| $circleField = ''; | |||
| if ($share->hasCircle()) { | |||
There was a problem hiding this comment.
I don't quite understand when a ShareWrapper has a circle and when it does not. We might also want to skip all $shares without a circle.
juliusknorr
approved these changes
Feb 12, 2025
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1714 (comment)