ci: run PHP test only if something related changed - #8822
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
7df0a07 to
b4c69a4
Compare
Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
b4c69a4 to
5a6584a
Compare
|
Don't merge this yet... we should make these changes on the rest of the workflows also https://github.com/nextcloud/calendar/blob/main/.github/workflows/lint-php-cs.yml https://github.com/nextcloud/calendar/blob/main/.github/workflows/lint-php.yml I can do it if you are too busy |
Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
|
Hm, I think I still need to correctly configure how the summaries run so that CI don't run PHP jobs are not stuck... |
Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
|
@SebastianKrupinski Can be reviewed again in. Here is how it looks when the tests are skipped #8823 |
|
|
||
| if: always() | ||
|
|
||
| name: php-cs-lint-summary |
There was a problem hiding this comment.
Adding this job, we will need to change the required jobs that gate merges.
From lint-php-cs/lint to lint-php-cs/summary
There was a problem hiding this comment.
Why do we need a different job gate? Your test Ci ran correctly
There was a problem hiding this comment.
#8823 did not open a PR to main so. I think we have the gates only for PRs to main (and maybe the stable branches?)
SebastianKrupinski
left a comment
SebastianKrupinski
left a comment
There was a problem hiding this comment.
Looks good to me
From your user CI test branch
Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
2 participants
🤖 AI (if applicable)