fix: event creation with alarm

[SebastianKrupinski]

Summary

• Fixes modal crash when creating a new event with calendars set

• Partially reverses refactor: stop passing redundant calendarObjectInstance #8737

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[SebastianKrupinski]

/backport to stabler6.6

[odzhychko]

Code looks good. Works as expected.

Thx for fixing what I broke...

[odzhychko]

thought(non-blocking): addAlarmToCalendarObjectInstance and removeAlarmFromCalendarObjectInstance should eventually move to util/alarm.js.

util/alarm.js#updateDefaultAlarm should not access the calendarObjectInstanceStore because in general stores can access utils, but utils should never access stores.

Also use of calendarsStore() can be removed by passing calendar as parameter.

[SebastianKrupinski]

util/alarm.js#updateDefaultAlarm should not access the calendarObjectInstanceStore because in general stores can access utils, but utils should never access stores.

I agree. This will need to be refactored at some point.

And mp, we all miss things... 10 years of spaghetti code to fix.

[backportbot]

The backport to stabler6.6 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stabler6.6
git pull origin stabler6.6

# Create the new backport branch
git checkout -b backport/8797/stabler6.6

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 104e4d51

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8797/stabler6.6

Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/8797/stabler6.6')
fatal: not a valid object name: 'origin/stabler6.6'

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[odzhychko]

/backport to stable6.6