fix: update, delete, accept, decline all occurrences by SebastianKrupinski · Pull Request #7600 · nextcloud/calendar

SebastianKrupinski · 2025-10-20T00:18:07Z

Summary

Fixed logic to update all occurrences of a recurring event
Fixed logic to delete all occurrences of a recurring event
Fixed logic to accept all occurrences of a recurring event
Fixed logic to decline all occurrences of a recurring event
Resolves: Add button to update all occurrences #3355
Resolves: Delete all occurrences, including past #6873
Resolves: Can't accept a recursive event from the calendar web UI #5666
Resolves: Accept or decline all future recurrences #6700
Resolves: Treat repeated events as a single object #4225
Resolves: Scared to click Accept/Decline on a recurring event #4368
Resolves: Missing “apply to all/this/this and following” options for recurring events in calendar #12142 #7771
Resolves: Web UI: Accept/Decline this and all future recurrences #6146
Resolves: couple more that I can not find atm

Logic Changes

As organizer all actions, update and delete, are applicable to either the this occurrence, this occurrence and all future, and all occurrences, this is manually controlled with no "why did this happen"

As participant all actions are restricted based on the instance type of the event. normal series instance or exemption instance. When accepting/declining of updating a normal series instance the changes are applied to the entire series. When accepting/declining or updating a exemption instance, the changes are applied to the exemption instance.

codecov · 2025-10-20T00:19:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Jerome-Herbinet · 2026-02-02T08:41:10Z

Hi,
Any news about this development's progression ?
I think that this development is actually important for web UI end-users.
Thanks !

IT-Seezeit · 2026-02-17T11:49:08Z

Hello,

that's a big problem for us too. It would be great if that could be fixed soon.
Thanks

Jerome-Herbinet · 2026-04-25T16:56:57Z

@SebastianKrupinski ; may this PR resolve #6146 as well ?

SebastianKrupinski · 2026-04-28T13:38:16Z

@SebastianKrupinski ; may this PR resolve #6146 as well ?

That is the idea, I just need to figure out the best work flow logic.

SebastianKrupinski · 2026-08-25T16:41:26Z

PHP errors are unrelated

SebastianKrupinski · 2026-08-27T13:46:35Z

/backport to stable6.6

SebastianKrupinski · 2026-08-27T13:46:46Z

/backport to stable6.5

SebastianKrupinski · 2026-08-27T14:40:17Z

@odzhychko should be good now

odzhychko

Tested. Works as expected.

Aside from the failing tests,
https://github.com/nextcloud/calendar/pull/7600/changes#r3878791313 might be a blocking issues.

odzhychko · 2026-08-27T20:16:12Z

@@ -154,16 +185,10 @@ export default {
 		async setParticipationStatus(participationStatus) {


nit(non-blocking): changeAttendeesParticipationStatus is not unused.

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

odzhychko · 2026-08-31T13:53:58Z

 					logger.error('Could not find master component to save series-wide changes to')
 				} else {
+					const isBaseOccurrence = !eventComponent.originalRecurrenceId
+						|| eventComponent.originalRecurrenceId.compare(baseComponent.startDate) === 0


issue: eventComponent.originalRecurrenceId.compare(baseComponent.startDate) === 0 breaks if

Create event on Thursday

Set weekly recurrence on Mondays

Save

Edit time first occurrence

Actual: Seeing the warning and changes are discarded

Expected: Time change saved

Hey, I was not able to reproduce this

Nvm, managed to reproduce it

Good find btw, would have never thought of trying this

I'm not sure, if finding by recurrence ID can really be made robust.

Might be easier to record what instance the calendar started editing. Maybe a blunt solution like storing a copy of the original event (or only the original start/end dates) when starting to edit and then diffing with it on save.

I found the issue with your new scenario above. Its crashing on the date update

Its caused by @nextcloud/calendar-js's RecurrenceManager.updateStartDateOfMasterItem():

for (const recurrenceException of this.getRecurrenceExceptionIterator()) { // live Map iterator this.removeRecurrenceException(recurrenceException) // deletes current entry recurrenceException.recurrenceId.addDuration(difference) // shifts its key this.relateRecurrenceException(recurrenceException) // re-inserts under a NEW key }

Well lets see how many more libraries we can fix while trying to fix this functionality

nextcloud/calendar-js#923

I think I found part of the confusion, the event is not actually changing, its only showing the new time on the pop up

I modified the second event by one hour you can see the diff in the popup and actual event (also I did get a warning)

So I just need to make the pop state refresh when we do not allow time update

odzhychko · 2026-08-31T14:24:31Z

+
+						const dateTimeWasChanged = eventComponent.startDate.compare(eventComponent.originalRecurrenceId) !== 0
+							|| currentDuration.compare(originalDuration) !== 0
+


compare calculates correctly with timezones.

So warning is not shown (and changes are silently discarded), when uses changes the timezone but the actual UTC time stays identical.
Not sure, if this is an issue.

create repeating event A starting at 10AM Berlin/Europe

Edit changing timezone to London/Europe and start to 9AM

Save for series

Expected: The warning

Actual: No warning

Warning is show correctly when changing the time zone

Screencast.From.2026-09-01.16-20-31.mp4

Happens only if the UTC time stays the same after timezone change. E.g. user updates from "10 Europe/Madrid === 11 UTC" to "11 Europe/London === 11 UTC".

Becomes an issue, because (a) user sets timezone for a reason and (b) even if UTC time is same at time of comparison it might be different later for example if one time zone uses summer time/winter time and the other does not.

Probably just needs an additional check here, that timzone in start and end date stayed the same.

SebastianKrupinski · 2026-09-01T13:36:41Z

@odzhychko Do you mind giving this one last test!?

odzhychko

Looked and tested the fix for the last issue.
Found two broken edge case with regards to saving series.

I've seen that some more code changed in the meanwhile.
I'll try to look at it and retest PR from scratch after the know issues are fixed ^^

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

SebastianKrupinski self-assigned this Oct 20, 2025

SebastianKrupinski added this to 💌 📅 👥 Groupware team Oct 20, 2025

SebastianKrupinski added the 2. developing Work in progress label Oct 20, 2025

github-project-automation Bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Oct 20, 2025

SebastianKrupinski mentioned this pull request Apr 22, 2026

Missing “apply to all/this/this and following” options for recurring events in calendar #12142 #7771

Open

SebastianKrupinski force-pushed the fix/issue-3355-delete-update-all-occurrences branch 4 times, most recently from b9f5658 to 43c8c49 Compare April 25, 2026 14:02

SebastianKrupinski changed the title ~~fix: update, delete, accept, devline all occurrences~~ fix: update, delete, accept, decline all occurrences Aug 25, 2026

SebastianKrupinski force-pushed the fix/issue-3355-delete-update-all-occurrences branch 6 times, most recently from 928f361 to 9b343a4 Compare August 25, 2026 15:57

SebastianKrupinski requested a review from odzhychko August 25, 2026 16:40

SebastianKrupinski marked this pull request as ready for review August 25, 2026 16:41

SebastianKrupinski requested review from GVodyanov and tcitworld as code owners August 25, 2026 16:41

SebastianKrupinski added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 25, 2026

SebastianKrupinski force-pushed the fix/issue-3355-delete-update-all-occurrences branch from 9b343a4 to ebf29dc Compare August 27, 2026 13:46

backportbot Bot added the backport-request A backport was requested for this pull request label Aug 27, 2026

SebastianKrupinski force-pushed the fix/issue-3355-delete-update-all-occurrences branch from ebf29dc to 8b424b7 Compare August 27, 2026 14:39

SebastianKrupinski force-pushed the fix/issue-3355-delete-update-all-occurrences branch from 8b424b7 to cc7fd03 Compare August 27, 2026 15:14

odzhychko requested changes Aug 28, 2026

View reviewed changes

SebastianKrupinski force-pushed the fix/issue-3355-delete-update-all-occurrences branch from e2571ee to 32619c4 Compare August 31, 2026 12:58

SebastianKrupinski added 3 commits August 31, 2026 09:01

fix: update, delete, accept, devline all occurrences

69cbd00

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

fixup! fix: update, delete, accept, devline all occurrences

d447b1a

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

fixup! fix: update, delete, accept, devline all occurrences

c26c525

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

SebastianKrupinski force-pushed the fix/issue-3355-delete-update-all-occurrences branch from 32619c4 to c26c525 Compare August 31, 2026 13:02

odzhychko reviewed Aug 31, 2026

View reviewed changes

Comment thread src/store/calendarObjectInstance.js Outdated

odzhychko reviewed Aug 31, 2026

View reviewed changes

SebastianKrupinski requested a review from odzhychko August 31, 2026 15:49

SebastianKrupinski mentioned this pull request Aug 31, 2026

fix: no discard dialog after editing recurring event #8808

Closed

odzhychko requested changes Sep 1, 2026

View reviewed changes

SebastianKrupinski force-pushed the fix/issue-3355-delete-update-all-occurrences branch from 70a63fe to 56588d5 Compare September 1, 2026 17:38

fixup! fix: update, delete, accept, devline all occurrences

afb5911

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

SebastianKrupinski force-pushed the fix/issue-3355-delete-update-all-occurrences branch from 56588d5 to afb5911 Compare September 1, 2026 18:29

SebastianKrupinski requested a review from odzhychko September 1, 2026 18:30

odzhychko mentioned this pull request Sep 2, 2026

fix: recurrance recalulation with excemption nextcloud/calendar-js#923

Open

1 task

		@@ -154,16 +185,10 @@ export default {
		async setParticipationStatus(participationStatus) {


		const dateTimeWasChanged = eventComponent.startDate.compare(eventComponent.originalRecurrenceId) !== 0
		\|\| currentDuration.compare(originalDuration) !== 0

Uh oh!

Conversation

SebastianKrupinski commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Logic Changes

Uh oh!

codecov Bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Jerome-Herbinet commented Feb 2, 2026

Uh oh!

IT-Seezeit commented Feb 17, 2026

Uh oh!

Jerome-Herbinet commented Apr 25, 2026

Uh oh!

SebastianKrupinski commented Apr 28, 2026

Uh oh!

SebastianKrupinski commented Aug 25, 2026

Uh oh!

SebastianKrupinski commented Aug 27, 2026

Uh oh!

SebastianKrupinski commented Aug 27, 2026

Uh oh!

SebastianKrupinski commented Aug 27, 2026

Uh oh!

odzhychko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SebastianKrupinski commented Sep 1, 2026

Uh oh!

odzhychko left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SebastianKrupinski commented Oct 20, 2025 •

edited

Loading

codecov Bot commented Oct 20, 2025 •

edited

Loading