Skip to content

Use new auto folder creation feture available since Nextcloud 32 - #17618

Open
daniele-verducci wants to merge 9 commits into
masterfrom
feature/create-folder-during-upload
Open

Use new auto folder creation feture available since Nextcloud 32#17618
daniele-verducci wants to merge 9 commits into
masterfrom
feature/create-folder-during-upload

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Use new auto folder creation feture available since Nextcloud 32 instead of explicitly creating folders before an upload.
The library PR is: nextcloud/android-library#2141

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@github-actions

github-actions Bot commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk (165M)
QR code Open the QR code for this download
Commit 3d0053b
Version 17618
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@daniele-verducci
daniele-verducci force-pushed the feature/create-folder-during-upload branch from c039a5d to 5ad7286 Compare September 14, 2026 15:54
@daniele-verducci daniele-verducci added this to the Nextcloud App 36.0.0 milestone Sep 14, 2026
@daniele-verducci

daniele-verducci commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

This is ready to review

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@daniele-verducci daniele-verducci mentioned this pull request Sep 14, 2026
Open
2 tasks
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

stable22-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17618-IT-stable22-16-20

alperozturk96
alperozturk96 requested changes Sep 15, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/operations/UploadFileOperation.java Outdated
Comment thread app/src/main/java/com/owncloud/android/operations/UploadFileOperation.java Outdated
@daniele-verducci
daniele-verducci force-pushed the feature/create-folder-during-upload branch 2 times, most recently from 8ecd813 to 671bc32 Compare September 15, 2026 09:39
@daniele-verducci

daniele-verducci commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

Hey @alperozturk96 , thanks for the review! I fixed it!

@daniele-verducci

daniele-verducci commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

Tests are failing, I'm checking them

@daniele-verducci
daniele-verducci force-pushed the feature/create-folder-during-upload branch from d2cda94 to d03927c Compare September 16, 2026 09:46
@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17618-IT-master-10-11

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

stable35-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17618-IT-stable35-10-14

daniele-verducci and others added 5 commits September 16, 2026 18:30
@daniele-verducci
feature/create-folder-during-upload: use new auto folder creation fea…
2734df5 
…ture

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Updated android-library
0dcc1b4 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Working new auto folder creation feature on uploads
d92016b 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci @alperozturk96
Apply suggestion from @alperozturk96
47fbc33 
Co-authored-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Use isOlderThan on capabilities for code readability
8924ac6 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Rebased
66e0c5d 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Moved dir tree creation to extensions (automatic java to kotlin conve…
e9a612a 
…rsion)

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Refactored converted kotlin to a more idiomatic one
fdf5b4b 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Create local folders metadata to reflect server's auto folder creation
3d0053b 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
daniele-verducci force-pushed the feature/create-folder-during-upload branch from d03927c to 3d0053b Compare September 16, 2026 16:31
@daniele-verducci

daniele-verducci commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

Tests should be fixed now, let's see next CI run

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness5858
Dodgy code186185
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3736
Security1818
Total360358

@codecov

codecov Bot commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.90476% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ncloud/android/operations/UploadFileOperation.java 30.43% 9 Missing and 7 partials ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky
@alperozturk96 alperozturk96 Awaiting requested review from alperozturk96

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

2. developing

Projects

None yet

Milestone

Nextcloud App 36.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@daniele-verducci @alperozturk96