Derive grid column count from the width the list is given - #17542
sandbranch wants to merge 1 commit into
Conversation
The number of grid columns came straight from the stored zoom preference and never looked at how wide the window actually is, so a phone in portrait and a tablet in landscape both showed the same three columns. onConfigurationChanged only ever clamped the count downwards, which meant rotating to landscape raised the limit but never added a column. Add a GridLayoutManager that works out its own column count from the width it is given during layout, and hand it a target column width instead of a column count. The target width is a dimension resource, so it can be adjusted per screen size later without touching this code. The width has to be read during layout. The display metrics are not a usable substitute: they describe the display rather than the space the list occupies, they are not yet meaningful while the view is being created, and during a rotation they can still describe the previous orientation, which produced a portrait grid laid out to the width of a landscape screen. Pinch to zoom keeps working and is still persisted. It now sets how large the cells are rather than a fixed column count, so a zoom level chosen in portrait carries over to landscape instead of being lost. Addresses part of the grid item of nextcloud#6769. Signed-off-by: David Sandquist <sandquist@gmail.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
1 participant
Addresses part of the grid item of #6769 ("span list/grid view across whole area").
Problem
The number of grid columns comes straight from the stored zoom preference and never looks at how wide the window actually is, so a phone in portrait and a tablet in landscape both show the same three columns.
onConfigurationChangedonly ever clamps the count downwards:so rotating to landscape raises the limit but never adds a column.
Fix
Add a
GridLayoutManagerthat works out its own column count from the width it is given during layout, and hand it a target column width instead of a column count. The target is a dimension resource (grid_item_default_width, 140dp), so it can be adjusted per screen size later without touching this code.The width has to be read during layout. The display metrics are not a usable substitute: they describe the display rather than the space the list occupies, they are not yet meaningful while the view is being created, and during a rotation they can still describe the previous orientation. I tried them first and got a portrait grid laid out to the width of a landscape screen (7 columns instead of 3), which is what prompted the layout-time approach.
Pinch to zoom keeps working and is still persisted. It now sets how large the cells are rather than a fixed column count, so a zoom level chosen in portrait carries over to landscape instead of being lost.
Testing
Measured on real devices, with the resolved width and column count logged:
The 140dp default was chosen so that a phone in portrait stays at three columns, i.e. existing phone users see no change at all; only wider windows gain columns.