Let grid file names wrap onto a second line - #17541
sandbranch wants to merge 1 commit into
Conversation
Grid labels were a single line ellipsized in the middle. On narrower cells that left names unreadable and sometimes indistinguishable, with two different folders both rendering as "Re...es". Allow the label a second line so a long name wraps instead of being cut, while names that fit keep using a single line and no extra height. Signed-off-by: David Sandquist <sandquist@gmail.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
1 participant
Problem
Grid labels are a single line ellipsized in the middle. On narrower cells that leaves names unreadable, and sometimes indistinguishable: two different folders in my own account both rendered as
Re...es.Fix
Allow the label a second line, so a long name wraps instead of being cut. Names that already fit keep using a single line and take no extra height, so cells with short names are unchanged.
Only
grid_item.xmlchanges:singleLinebecomesmaxLines="2"and the fixed height becomeswrap_content.Testing
Checked on a Samsung S23 and a Lenovo Tab P11 Pro (2nd gen), portrait and landscape.
Note
The bidirectional file name container in the same layout still uses a single line. Wrapping it means wrapping a name and its extension across two views, which needs more care than this change, so I left it alone rather than guess.