Chore: Improve Gradle Configuration #15783
Conversation
alperozturk96
force-pushed
the
chore/gradle
branch
from
70edcfb to
03fc939
Compare
- Rename build.gradle to build.gradle.kts - Rename settings.gradle to settings.gradle - Rename jacoco.gradle to jacoco.gradle.kts - Refactor some entries in the libs.versions.toml - Change running test task from to run jacoco task to trigger task, now it's reversed... we run the test task that will trigger the jacoco task Signed-off-by: Jimly Asshiddiqy <[email protected]> Signed-off-by: Jimly Asshiddiqy <[email protected]>
- Rename build.gradle to build.gradle.kts - Rename settings.gradle to settings.gradle - Rename jacoco.gradle to jacoco.gradle.kts - Refactor some entries in the libs.versions.toml - Change running test task from to run jacoco task to trigger task, now it's reversed... we run the test task that will trigger the jacoco task Signed-off-by: Jimly Asshiddiqy <[email protected]>
- Move buildConfig - Setup credential from .gradle/config.properties Signed-off-by: Jimly Asshiddiqy <[email protected]> Signed-off-by: Jimly Asshiddiqy <[email protected]>
alperozturk96
force-pushed
the
chore/gradle
branch
from
399d12b to
9807c02
Compare
- Use the right variable for testInstrumentationRunnerArguments Signed-off-by: Jimly Asshiddiqy <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Jimly Asshiddiqy <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
…PreferenceActivity for SettingsActivity Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]> # Conflicts: # build.gradle
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: Jimly Asshiddiqy <[email protected]>
|
After solving Git conflicts, merging and pushing directly can cause a lot of file changes and unnecessary commits. Instead, you can rebase to the latest master and then force-push. This way, you’ll see only the related changes and exact commits. Tips: When solving Git conflicts, accept master’s changes. This approach makes conflict resolution much easier, especially when the differences are just dependency version updates you can simply replace those. I hope it helps, thank you. @jimlyas |
|
@alperozturk96 , thanks for the input. Sorry for making a mess with this PR. Is there anything I can do? Or should I just close this PR and make a new one from scratch? |
|
Hi @jimlyas |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@alperozturk96 @AndyScherzinger @tobiasKaminsky I've closed this PR and opened a new one here: |
4 participants
Description
This Merge Include:
Migrating from Groovy DSL to Kotlin DSL
Migrate from Groovy to Kotlin DSL for the build script
build.gradletobuild.gradle.ktsjacoco.gradletojacoco.gradle.ktssettings.gradletosettings.gradle.ktsapp/build.gradletoapp/build.gradle.ktsappscan/build.gradletoappscan/build.gradle.ktsthere's some improvement to like grouping some configuration and setup in one place.
Generating jacoco report task
Previously, the project run generate report task to trigger the unit test task.
This PR reverse that, so we only need to run the unit test and after it finished, then Gradle will run the task that generate jacoco report.
Another reason being is, when running the unit test task, Android Studio will display Run Test window that help visibility to see which task is passed and which task is failed. Like this:
evidence.mp4
Version Catalog
Other
From previous setup, to run "checkstyle" task it needs
checkstyle.xmlbut I can't find it anywhere inside the project.