-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Chore: Improve Gradle Configuration #15783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jimlyas
wants to merge
4
commits into
nextcloud:master
Choose a base branch
from
jimlyas:chore/gradle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70edcfb
to
03fc939
Compare
alperozturk96
requested changes
Oct 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Thank you for the excellent PR 🚀. This is a fantastic addition.
Could you please update the PR to address the points I’ve highlighted?
- Rename build.gradle to build.gradle.kts - Rename settings.gradle to settings.gradle - Rename jacoco.gradle to jacoco.gradle.kts - Refactor some entries in the libs.versions.toml - Change running test task from to run jacoco task to trigger task, now it's reversed... we run the test task that will trigger the jacoco task Signed-off-by: Jimly Asshiddiqy <[email protected]> Signed-off-by: Jimly Asshiddiqy <[email protected]>
- Rename build.gradle to build.gradle.kts - Rename settings.gradle to settings.gradle - Rename jacoco.gradle to jacoco.gradle.kts - Refactor some entries in the libs.versions.toml - Change running test task from to run jacoco task to trigger task, now it's reversed... we run the test task that will trigger the jacoco task Signed-off-by: Jimly Asshiddiqy <[email protected]>
- Move buildConfig - Setup credential from .gradle/config.properties Signed-off-by: Jimly Asshiddiqy <[email protected]> Signed-off-by: Jimly Asshiddiqy <[email protected]>
399d12b
to
9807c02
Compare
alperozturk96
requested changes
Oct 14, 2025
- Use the right variable for testInstrumentationRunnerArguments Signed-off-by: Jimly Asshiddiqy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Merge Include:
Migrating from Groovy DSL to Kotlin DSL
Migrate from Groovy to Kotlin DSL for the build script
build.gradle
tobuild.gradle.kts
jacoco.gradle
tojacoco.gradle.kts
settings.gradle
tosettings.gradle.kts
app/build.gradle
toapp/build.gradle.kts
appscan/build.gradle
toappscan/build.gradle.kts
there's some improvement to like grouping some configuration and setup in one place.
Generating jacoco report task
Previously, the project run generate report task to trigger the unit test task.
This PR reverse that, so we only need to run the unit test and after it finished, then Gradle will run the task that generate jacoco report.
Another reason being is, when running the unit test task, Android Studio will display Run Test window that help visibility to see which task is passed and which task is failed. Like this:
evidence.mp4
Version Catalog
Other
From previous setup, to run "checkstyle" task it needs
checkstyle.xml
but I can't find it anywhere inside the project.