Skip to content

Conversation

jimlyas
Copy link

@jimlyas jimlyas commented Oct 13, 2025

Description

This Merge Include:

Migrating from Groovy DSL to Kotlin DSL

Migrate from Groovy to Kotlin DSL for the build script

  • build.gradle to build.gradle.kts
  • jacoco.gradle to jacoco.gradle.kts
  • settings.gradle to settings.gradle.kts
  • app/build.gradle to app/build.gradle.kts
  • appscan/build.gradle to appscan/build.gradle.kts

there's some improvement to like grouping some configuration and setup in one place.

Generating jacoco report task

Previously, the project run generate report task to trigger the unit test task.

This PR reverse that, so we only need to run the unit test and after it finished, then Gradle will run the task that generate jacoco report.

Another reason being is, when running the unit test task, Android Studio will display Run Test window that help visibility to see which task is passed and which task is failed. Like this:

evidence.mp4

Version Catalog

  • Migrate from extras-based versioning to use version catalog for versioning
  • Implement all the convention Gradle plugin from version catalog
  • Group dependencies together using bundles

Other

From previous setup, to run "checkstyle" task it needs checkstyle.xml but I can't find it anywhere inside the project.

  • Tests written, or not not needed

Copy link
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Thank you for the excellent PR 🚀. This is a fantastic addition.

Could you please update the PR to address the points I’ve highlighted?

Jimly Asshiddiqy added 3 commits October 14, 2025 08:55
- Rename build.gradle to build.gradle.kts
- Rename settings.gradle to settings.gradle
- Rename jacoco.gradle to jacoco.gradle.kts
- Refactor some entries in the libs.versions.toml
- Change running test task from to run jacoco task to trigger task, now it's reversed... we run the test task that will trigger the jacoco task

Signed-off-by: Jimly Asshiddiqy <[email protected]>
Signed-off-by: Jimly Asshiddiqy <[email protected]>
- Rename build.gradle to build.gradle.kts
- Rename settings.gradle to settings.gradle
- Rename jacoco.gradle to jacoco.gradle.kts
- Refactor some entries in the libs.versions.toml
- Change running test task from to run jacoco task to trigger task, now it's reversed... we run the test task that will trigger the jacoco task

Signed-off-by: Jimly Asshiddiqy <[email protected]>
- Move buildConfig
- Setup credential from .gradle/config.properties

Signed-off-by: Jimly Asshiddiqy <[email protected]>
Signed-off-by: Jimly Asshiddiqy <[email protected]>
- Use the right variable for testInstrumentationRunnerArguments

Signed-off-by: Jimly Asshiddiqy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants