Skip to content

fix(NcAppContent): adapt to new emitted event object with splitpanes ^4.0.0 #6950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

wofferl
Copy link
Contributor

@wofferl wofferl commented May 23, 2025

☑️ Resolves

From Splitpanes Release Notes

Version 4.0.0

Refactored all the emitted events to always return a single object containing as much information as possible. E.g. event, index, pane, prevPane, nextPane, panes.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.25%. Comparing base (9d3b7ac) to head (9321a93).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/components/NcAppContent/NcAppContent.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6950      +/-   ##
==========================================
+ Coverage   43.22%   43.25%   +0.03%     
==========================================
  Files         254      254              
  Lines       18942    18930      -12     
  Branches      948      948              
==========================================
+ Hits         8187     8189       +2     
+ Misses      10641    10629      -12     
+ Partials      114      112       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@susnux susnux requested review from st3iny and ShGKme May 25, 2025 15:46
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels May 25, 2025
@susnux susnux merged commit 4db2f93 into nextcloud-libraries:main May 26, 2025
23 of 24 checks passed
@susnux susnux mentioned this pull request May 26, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NcAppContent] pane resize broken with 9.0.0-rc.1
3 participants