-
Notifications
You must be signed in to change notification settings - Fork 94
feat(NcActionButton): introduce description
prop
#6932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
subline
prop
Looks good! I'm wondering if we should align the icon with the title instead of centering it in the whole action item element. I remember @marcoambrosini had some thoughts about this? |
Yes, to tidy up things visually, the icon should be aligned with the title of the actionbutton |
It's unrelated, applied to all action items |
Signed-off-by: Maksim Sukharev <[email protected]>
41c55b2
to
4d393e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the icon alignment is a separate issue, approving this PR for default
+ subline
👍
If this is semantically a description, maybe also name the prop |
I would second that (seems to be also a bit more consistent with our prop names in general). |
Signed-off-by: Maksim Sukharev <[email protected]>
4d393e4
to
5a6b062
Compare
subline
propdescription
prop
/backport to stable8 |
☑️ Resolves
name
prop +default
slot is a bit bulkydefault
slot +subline
prop🖼️ Screenshots
Documentation screenshot:

Same content comparison:

🚧 Tasks
🏁 Checklist
stable8
for maintained Vue 2 version or not applicable