Skip to content

feat(NcActionButton): introduce description prop #6932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • There might be a need to use a button as 'action name' + 'description'
  • Current solution: name prop + default slot is a bit bulky
  • Alternative with this PR: default slot + subline prop

🖼️ Screenshots

Documentation screenshot:
image

Same content comparison:
image

🚧 Tasks

  • First commit: check if it's non-breaking

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@Antreesy Antreesy added this to the 9.0.0 milestone May 19, 2025
@Antreesy Antreesy requested review from susnux, ShGKme and DorraJaouad May 19, 2025 13:04
@Antreesy Antreesy self-assigned this May 19, 2025
@Antreesy Antreesy added enhancement New feature or request 3. to review Waiting for reviews feature: actions Related to the actions components labels May 19, 2025
@Antreesy Antreesy changed the title fix(NcActionButton): wrap items under single wrapper feat(NcActionButton): introduce subline prop May 19, 2025
@Antreesy Antreesy requested a review from nimishavijay May 23, 2025 08:28
@nimishavijay
Copy link

Looks good!

I'm wondering if we should align the icon with the title instead of centering it in the whole action item element. I remember @marcoambrosini had some thoughts about this?

@marcoambrosini
Copy link
Contributor

Yes, to tidy up things visually, the icon should be aligned with the title of the actionbutton

@ShGKme
Copy link
Contributor

ShGKme commented May 23, 2025

I'm wondering if we should align the icon with the title instead of centering it in the whole action item element. I remember @marcoambrosini had some thoughts about this?

It's unrelated, applied to all action items

@susnux susnux mentioned this pull request May 26, 2025
15 tasks
@Antreesy Antreesy force-pushed the feat/noid/action-button-subline branch from 41c55b2 to 4d393e4 Compare May 27, 2025 06:52
@Antreesy Antreesy requested a review from ShGKme May 27, 2025 06:52
Copy link

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the icon alignment is a separate issue, approving this PR for default + subline 👍

@ShGKme
Copy link
Contributor

ShGKme commented May 27, 2025

  • There might be a need to use a button as 'action name' + 'description'

If this is semantically a description, maybe also name the prop description?

@susnux
Copy link
Contributor

susnux commented May 27, 2025

If this is semantically a description, maybe also name the prop description?

I would second that (seems to be also a bit more consistent with our prop names in general).

@Antreesy Antreesy force-pushed the feat/noid/action-button-subline branch from 4d393e4 to 5a6b062 Compare May 28, 2025 07:41
@Antreesy Antreesy changed the title feat(NcActionButton): introduce subline prop feat(NcActionButton): introduce description prop May 28, 2025
@Antreesy Antreesy merged commit d247581 into main May 28, 2025
25 checks passed
@Antreesy Antreesy deleted the feat/noid/action-button-subline branch May 28, 2025 08:50
@Antreesy
Copy link
Contributor Author

/backport to stable8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: actions Related to the actions components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants