Skip to content

docs: enhance NcAppSidebar documentation #6913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • join some simple examples into one
  • wrap all examples in mock of NcAppContent > NcContent with basic styling (these components can not be used in examples several times on one page)
  • implement open/close logic for all examples
  • fix some typos in comments and docs
  • lint file

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

- join some simple examples into one
- wrap all examples in mock of NcAppContent > NcContent with basic styling (these components can not be used in examples several times on one page)
- implement open/close logic for all examples
- fix some typos in comments and docs
- lint file

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy added this to the 9.0.0-rc.2 milestone May 13, 2025
@Antreesy Antreesy requested review from susnux and ShGKme May 13, 2025 17:15
@Antreesy Antreesy self-assigned this May 13, 2025
@Antreesy Antreesy added 3. to review Waiting for reviews feature: documentation Related to the documentation feature: app-sidebar Related to the app-sidebar component labels May 13, 2025
@susnux susnux mentioned this pull request May 26, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component feature: documentation Related to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants