Skip to content

refactor: use NcIconSvgWrapper with directional property where needed #6767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 10, 2025

☑️ Resolves

Simplify RTL handling for icons a bit.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@susnux susnux added 3. to review Waiting for reviews refactor ♻️ Pull request that is neither a fix nor a feature labels Apr 10, 2025
@susnux susnux requested review from ShGKme, hamza221 and Antreesy April 10, 2025 15:20
@susnux susnux added this to the 9.0.0 milestone Apr 10, 2025
@susnux
Copy link
Contributor Author

susnux commented Apr 10, 2025

/backport to stable8

@susnux susnux force-pushed the chore/rtl-icon branch from 5482b52 to 28fb41f Compare May 6, 2025 14:38
@susnux susnux mentioned this pull request May 26, 2025
15 tasks
@susnux susnux requested a review from Antreesy May 27, 2025 08:23
@susnux susnux requested a review from Antreesy May 27, 2025 09:55
@susnux susnux merged commit b8d3a49 into main May 28, 2025
25 checks passed
@susnux susnux deleted the chore/rtl-icon branch May 28, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews refactor ♻️ Pull request that is neither a fix nor a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants