-
Notifications
You must be signed in to change notification settings - Fork 94
fix(dialogs/spawnDialog)!: support vue-devtool but lose appContext #6752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Grigorii K. Shartsev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense and is cleaner, but quite some negative aspects for just some DX.
I tried many options and found no way to have both app context and independent rendering. We can either hack with re-registering all global component, re-providing everything from providers. Or manually add |
And as far as I know, there is no case where we need it at the moment. |
I think this is quite complex solution for a rare condition (when there is even one). So yes lets stick with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's see how it works in app, when we get to it
☑️ Resolves
spawnDialog
or add a new function #6731vue-devtools
getCurrentInstance
only works when the dialog is spawned in the setup context, so doesn't even work in a click handlerThis looses
appContext
.Workarounds:
provide/inject
- provide directly from the root dialog componentactivePinia
, or via provide in the root dialog componentAlternative:
🏁 Checklist
stable8
for maintained Vue 2 version.