-
Notifications
You must be signed in to change notification settings - Fork 94
[stable8] fix(NcAppContent): don't remove list when showing details in mobile or no-split mode #6261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable8] fix(NcAppContent): don't remove list when showing details in mobile or no-split mode #6261
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stable8 #6261 +/- ##
==========================================
Coverage ? 43.11%
==========================================
Files ? 161
Lines ? 4112
Branches ? 1070
==========================================
Hits ? 1773
Misses ? 2220
Partials ? 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d82dbf3
to
c2832fa
Compare
c2832fa
to
0bffe7b
Compare
hi, sorry for the late reply, i wrote on our frontend talk room, so more people are involved to get a decision. |
0bffe7b
to
3da5624
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense from my view. but should be checked with mail
…r no-split mode Signed-off-by: Wolfgang <[email protected]>
3da5624
to
c27d399
Compare
/backport to main |
☑️ Resolves
As mentioned in #6204 the change in 8.10.0 causes the item list to rebuild every time the details of an item are shown.
With a dynamic list like in the news app, where read items are removed from the list when refreshing it, this means that the selected item you looked at the details are gone immediately when you close the details.
It also affects the performance, because of the rebuilding when closing the details, which is notable on mobile devices.
I think there is no technical reason to delete it, so it is better to just hide the list.