Skip to content

[stable8] fix(NcAppContent): don't remove list when showing details in mobile or no-split mode #6261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

wofferl
Copy link
Contributor

@wofferl wofferl commented Nov 23, 2024

☑️ Resolves

As mentioned in #6204 the change in 8.10.0 causes the item list to rebuild every time the details of an item are shown.
With a dynamic list like in the news app, where read items are removed from the list when refreshing it, this means that the selected item you looked at the details are gone immediately when you close the details.
It also affects the performance, because of the rebuilding when closing the details, which is notable on mobile devices.

I think there is no technical reason to delete it, so it is better to just hide the list.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable8@0d00038). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             stable8    #6261   +/-   ##
==========================================
  Coverage           ?   43.11%           
==========================================
  Files              ?      161           
  Lines              ?     4112           
  Branches           ?     1070           
==========================================
  Hits               ?     1773           
  Misses             ?     2220           
  Partials           ?      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wofferl wofferl force-pushed the fix_appcontent_list branch from d82dbf3 to c2832fa Compare January 11, 2025 11:32
@wofferl
Copy link
Contributor Author

wofferl commented Feb 4, 2025

@GretaD @ShGKme Is there any information on this problem, whether the old behavior should be restored or whether it will remain as it is in the future.

@wofferl wofferl force-pushed the fix_appcontent_list branch from c2832fa to 0bffe7b Compare February 14, 2025 11:14
@GretaD
Copy link
Contributor

GretaD commented Feb 14, 2025

hi, sorry for the late reply, i wrote on our frontend talk room, so more people are involved to get a decision.

@wofferl wofferl force-pushed the fix_appcontent_list branch from 0bffe7b to 3da5624 Compare April 1, 2025 18:53
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense from my view. but should be checked with mail

@susnux susnux requested review from st3iny and GretaD April 1, 2025 19:20
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Apr 1, 2025
@wofferl wofferl force-pushed the fix_appcontent_list branch from 3da5624 to c27d399 Compare April 12, 2025 08:22
@susnux susnux requested a review from ShGKme April 16, 2025 08:04
@susnux susnux merged commit 17630ba into nextcloud-libraries:stable8 Apr 17, 2025
22 checks passed
@susnux
Copy link
Contributor

susnux commented Apr 17, 2025

/backport to main

@wofferl wofferl deleted the fix_appcontent_list branch April 23, 2025 19:00
@Antreesy Antreesy changed the title fix(NcAppContent): don't remove list when showing details in mobile or no-split mode [stable8] fix(NcAppContent): don't remove list when showing details in mobile or no-split mode Apr 24, 2025
@Antreesy Antreesy added this to the 8.26.0 milestone Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NcAppContent] list is rebuild every time when details were shown with no-split or mobile view
6 participants