fix(qwik): don't build server deps on client #12723
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@wmertens is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
|
Any chance of a review? It's a small change and it prevents people from using @authjs/qwik with vite 6 |
|
This is blocking QwikDev/qwik#7382 |
|
@ThangHuuVu @balazsorban44 if you have a couple of minutes to review 🙏 . Ideally we'd like to upgrade to vite 6, but we want to make sure those using auth js continue to have a seamless experience 🙂 |
|
@thejackshelton, thank you for following up. Since Vite is the foundation for many projects, can you please follow this PR again to speed up its merging? |
The optimizer doesn't fully remove server imports and it helps to put `isServer` guards so server-side modules are not bundled for the client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Put some
isServerguards so @auth/core is not bundled for the client, since that breaks the build with Vite 6.The culprit is the environment configuration.
🧢 Checklist
🎫 Affected issues
none created
📌 Resources