Feat/add gitee provider #12475
Open
Feat/add gitee provider #12475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@wushide is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
halvaradop
reviewed
Jan 17, 2025
Comment on lines
+24
to
+25
| const baseUrl = "https://gitee.com"; | ||
| const apiBaseUrl = "https://gitee.com/api/v5"; |
There was a problem hiding this comment.
It is not necessary to use these two variables, since apiBaseUrl only adds the path /api/v5 to baseUrl
Comment on lines
+31
to
+36
| authorization: { | ||
| url: `${baseUrl}/oauth/authorize`, | ||
| params: { | ||
| scope: "", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
If no additional configuration is needed, there’s no need to use the object. Simply use the API route directly.
Comment on lines
+37
to
+42
| token: { | ||
| url: `${baseUrl}/oauth/token`, | ||
| params: { | ||
| grant_type: "authorization_code", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
The grant_type is set to authorization_code by default, so there’s no need to use the object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
This will add a login method to Gitee. I have already resolved the type issue, as there was previously a type gap.
🧢 Checklist
🎫 Affected issues
📌 Resources