-
Notifications
You must be signed in to change notification settings - Fork 99
[그리디] 강동현 자동차 경주 미션 3,4 단계 제출합니다. #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mintcoke123
wants to merge
50
commits into
next-step:mintcoke123
Choose a base branch
from
mintcoke123:step_4_TDD_refactoring
base: mintcoke123
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
ec977e0
feat: Car 클래스 생성
mintcoke123 3f0445f
feat: RandomDigitGenerator 클래스 생성
mintcoke123 7df9482
test: Race 테스트코드 작성
mintcoke123 3ebb68d
refactor: 요구사항에 부합하게끔 (경주가 가능하게끔) Car.java 클래스 변경
mintcoke123 c671883
feat: 경주를 진행하는 Race클래스 생성
mintcoke123 36dbf6e
feat: 경주 관련 class 구현
mintcoke123 36984b7
refactor(임시저장): 파일구조 분리/클래스 캡슐화
mintcoke123 e2ba6f6
refactor: 유틸함수 분리, test까지 가능하도록 리팩터링
mintcoke123 cc07bf6
refactor: 테스트코드 추가, 단위테스트 세분화
mintcoke123 5c61abb
docs: README.md 파일 추가
mintcoke123 bf48666
refacor: stream 연산을 활용하여 코드 depth가 2이상이 되지 않도록 수정
mintcoke123 49ac5ef
chore: eol 규칙 준수
mintcoke123 ce2975d
chore: 코드 개행규칙 준수
mintcoke123 f122d22
chore: 코드 순서 정렬
mintcoke123 ecb605c
refactor: car 클래스 캡슐화 적용
mintcoke123 cc93719
refactor: carListGenearator가 이름을 입력받도록 변경
mintcoke123 7c4ac68
refactor: 객체의 책임에 따라 domain 과 utils 분리
mintcoke123 cfb1a00
refactor: 객체들의 캡슐화 진행, 테스트코드 리팩토링
mintcoke123 2eab03d
refactor: 경주 시작전에 모든 참가자들이 출발점에 있는지 확인
mintcoke123 a0e9167
refactor: 차 이름을 외부에서 가져온다고 가정, CarListGenerator 리팩토링
mintcoke123 4a63777
refactor: Car에서 정적팩토리메서드로 Car 선언
mintcoke123 e2609ba
refactor: 매직넘버로 상수관리
mintcoke123 cd29fb1
refactor: 필요없는 `stop` 매서드 제거
mintcoke123 600ac3b
chore:실행용 엔트리포인트 추가
mintcoke123 76b571e
refactor: 사용하지 않는 매서드 제거
mintcoke123 2b430b2
refactor: 게임 초기의 view 작성
mintcoke123 ae311f1
refactor: view 작성 완료
mintcoke123 f0c3fec
refactor: Main 컴포넌트 작동하게끔 수정
mintcoke123 0c09409
refactor: 요구사항에 맞게끔 메세지 줄바꿈
mintcoke123 e1d356b
refactor: controller와 view의 구체적 분리
mintcoke123 b49925d
refactor: 리네이밍, 요구사항 부합하게 변경
mintcoke123 af47e04
refactor: 전략 패턴으로 리팩토링
mintcoke123 19b1ab7
refactor: carTest 테스트코드 추가
mintcoke123 04b93c1
refactor: Race 전략패턴 방식으로 변경
mintcoke123 5133c61
refactor: 모든 model 로직 단위 테스트
mintcoke123 ad5232a
refactor: 전략 패턴 반영
mintcoke123 029ea6d
refactor: 입력 조건문 요구사항 반영
mintcoke123 ef3714a
docs: README.md 작성
mintcoke123 c8adcfb
refactor: mvc 패턴 세분화
mintcoke123 626f0ee
refactor: do-while 문 적용하여 RaceController 리팩토링
mintcoke123 0313518
chore: 코드 컨벤션 적용
mintcoke123 0a839cb
chore: editorconfig 파일 추가, 개행문자 적용
mintcoke123 96a19f7
refactor: getValidCarNames, getValidTurn의 관심사 분리
mintcoke123 1490281
refactor: 매직넘버 네이밍 컨벤션 수정
mintcoke123 38fd877
refactor: 이름 입력 검증로직 수정
mintcoke123 2aed197
refactor: 턴수 입력 검증로직 수정
mintcoke123 945ac06
test: carTest 테스트코드 리팩토링
mintcoke123 f18197e
test: 컨드롤러 테스트코드 추가
mintcoke123 d1f8b9b
Merge branch 'mintcoke123' into step_4_TDD_refactoring
mintcoke123 279cba2
refactor: 변수명 리네이밍
mintcoke123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
root = true | ||
|
||
[*] | ||
end_of_line = lf | ||
insert_final_newline = true | ||
charset = utf-8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import controller.RaceController; | ||
import utils.RandomDigitGenerator; | ||
import view.RaceInputView; | ||
import view.RaceOutputView; | ||
|
||
public class Main { | ||
public static void main(String[] args) { | ||
new RaceController( | ||
new RaceInputView(), | ||
new RaceOutputView(), | ||
new RandomDigitGenerator() | ||
).runRace(); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 부분 보시면 End Of Line 경고가 발생하고 있는데 확인 부탁드려요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵! 수정했습니다!