Skip to content

Fix tests related to next100 update #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mcidlaso merged 5 commits into from
Nov 21, 2025
Merged

Fix tests related to next100 update #55

mcidlaso merged 5 commits into from
Nov 21, 2025

Conversation

@gonzaponte
Copy link
Collaborator

@gonzaponte gonzaponte commented Jul 31, 2025 •
edited
Loading

We pushed through #54 to get everything asap. Now we fix the tests.

The results seem to depend on the machine somehow, so for now this is ignored.

@gonzaponte gonzaponte requested a review from carhc July 31, 2025 09:37
carhc
carhc reviewed Jul 31, 2025
View reviewed changes
Copy link
Contributor

@carhc carhc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

I have one small issue, thought. I suggest removing the x_range, y_range in the config files since they no longer play any role on the evolution computation, but maybe this is not the most suitable PR for that since that does not affect the tests.

Other than that, I think it's just the commented assert on test_scrip_runs_and_produces_correct_outputs, apparently machine-dependent. How should we proceed now?

@gonzaponte
Copy link
Collaborator Author

gonzaponte commented Jul 31, 2025

I suggest removing the x_range, y_range in the config files

Done.

I think it's just the commented assert on test_scrip_runs_and_produces_correct_outputs, apparently machine-dependent. How should we proceed now?

We have validated the code by other means, so I'm happy to ignore it for the time being

carhc
carhc approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@carhc carhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I'm happy to approve this now! Nice update to tie up loose ends of the previous PR. Good job!

@mcidlaso mcidlaso merged commit 35e4181 into next-exp:master Nov 21, 2025
1 check passed
mcidlaso pushed a commit that referenced this pull request Nov 21, 2025
@carhc @mcidlaso
55 Fix test related to next100 update
7664602 
#55

[author: gonzaponte]

We pushed through #54 to get everything asap. Now we fix the tests.

The results seem to depend on the machine somehow, so for now this is
ignored.

[reviewer: carhc]

I'm happy to approve this now! Nice update to tie up loose ends of the previous PR. Good job!
@gonzaponte gonzaponte deleted the fix-tests branch December 5, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carhc carhc carhc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gonzaponte @carhc @mcidlaso