Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update footer component #118

Merged
merged 6 commits into from
May 3, 2024
Merged

Update footer component #118

merged 6 commits into from
May 3, 2024

Conversation

nexmoe
Copy link
Owner

@nexmoe nexmoe commented May 3, 2024

No description provided.

nexmoe added 6 commits May 2, 2024 14:08
- Add TypeScript to script setup in Footer.vue
- Define interfaces for List, Sitemap, and Props in Footer.vue
- Render footer links dynamically based on sitemap data in Footer.vue
- Update config interface in config.ts to include footerLinks
- Import FooterSitemap interface in config.ts
- Pass siteName and sitemap data to LazyPublicFooter in default.vue
Changed primary color class in Catalog.vue from using hex values to using
semantic class names for better readability and consistency.
Changed the sitemap property in the Props interface to be optional by adding a question mark. Updated references to sitemap property to refer to props.sitemap. Also updated the sitemap prop in the default layout to config.footerLinks.
Updated the Footer component to make the sitemap prop optional by adding a '?' to the prop type. Also changed references to sitemap to use props.sitemap. Additionally, corrected typo in layouts/default.vue by changing 'config.stiemap' to 'config.footerLinks'.
Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
roam-space ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 3:32am

@nexmoe nexmoe merged commit d6feae3 into main May 3, 2024
3 checks passed
@nexmoe nexmoe deleted the update-footer-component branch May 3, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant