Open
Conversation
GitJIHO
approved these changes
Sep 9, 2025
Comment on lines
+75
to
+82
| supabase: | ||
| storage: | ||
| bucket: ${SUPABASE_BUCKET_NAME} | ||
| endpoint-url: ${SUPABASE_ENDPOINT_URL} | ||
| region: ${SUPABASE_REGION} | ||
| credentials: | ||
| access-key: ${SUPABASE_ACCESS_KEY} | ||
| secret-key: ${SUPABASE_SECRET_KEY} No newline at end of file |
Member
There was a problem hiding this comment.
추가된 값 배포 전에 노션에 최신화 부탁드립니다! 서버단에 바로 적용하겠습니다
Comment on lines
+21
to
+25
| public class StorageService { | ||
|
|
||
| private final AmazonS3 awsS3Client; | ||
| private final AmazonS3 supabaseS3Client; | ||
| private final StorageConfig storageConfig; |
Member
There was a problem hiding this comment.
지금은 꼭 필요할 것 같지는 않습니다만
확장성을 고려해서 포트 기반 구현체로 추후 리팩터링 과정에서 도입해도 좋을 것 같네영
anaconda77
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
배경
변경된 점
관련 이슈
close #136