WIP: Missing majority #1583
Merged
WIP: Missing majority #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use 'aca_year' (academic year) field to clarify which part of a calendar year the event is.
Display a CTA if not
Improve clarity
My local build failed these files (even though Travis didn't). These now work locally, so hopefully still work via Travis.
Where at least 4 of the start date, venue, poster, playwright, synopsis (excerpt), cast (or cast incomplete), crew (or crew incomplete) are missing from the show file. Erroneous 'and'
Still appears when show.ignore_missing is true (inherit behaviour of show_basic_details_missing
Caught some strange behaviours in existing shows.
Accidentally hid the synopsis, trivia and assets. Bad.
Sources: mllx.co.uk; ScotsGay; The Times
Adjust yaml for local build
As per show synopsis on ticketing website
Key events
Update 'Twinss'
Various minor additions
Adding programmes found in the depths of J Heil's NNT Google drive
quote marks where they shouldn't be
Change misspelled name closes #1648
Also add a link to the skeleton file
put degree level at start
How's this @samozzy ?
Document how we list musician roles
Adding Submitted Bios
Update chiedza_mcnab.md
* Create 20_21.md * Starting 20_21 Season Add show files ready for population * Update hello_world.md * Update hello_world.md * Update hello_world.md * Update far_apart.md * Update freshers_fringe.md * Update freshers_fringe.md * More Shows Created all shows that were in the 20/21 file * Update autumn_showers.md * Update autumn_showers.md * Update autumn_showers.md * Update familiar_strangers.md * Update familiar_strangers.md * Update autumn_showers.md * Update when_sally_met.md * Update faces.md * Update faces.md * Update what_could_be_worse.md * Update accelerate.md * Update speaking_solo.md * Update self_ish.md * Update the_show_must_go_on.md * Update 2021.md * Update accelerate.md * Update autumn_showers.md * Update familiar_strangers.md * Update freshers_fringe.md * Update what_could_be_worse.md * Update what_could_be_worse.md * Update when_sally_met.md * Update freshers_fringe.md * Update speaking_solo.md * Update the_show_must_go_on.md * Update speaking_solo.md * Update speaking_solo.md * Update 2021.md * Update accelerate.md * Update autumn_showers.md * Update faces.md * Update familiar_strangers.md * Update far_apart.md * Update freshers_fringe.md * Update hello_world.md * Update self_ish.md * Update the_show_must_go_on.md * Update what_could_be_worse.md * Update when_sally_met.md * Update freshers_fringe.md * Tidy Up Files tidying up the files cause i'm bored also removing the github images that don't need to be there * Fix freshers fringe hopefully fix build fail * Add Edinburgh Shows Adding final shows for 2020/2021 season * Update familiar_strangers.md * Update madhouse_ed.md * Update rocket_science_ed.md * Update madhouse_ed.md * Order Season Consolidate season sort values Co-authored-by: Ben Woodford <[email protected]>
A parent assigned incorrectly to a child
Create max_nichols.md
Where at least 4 of the start date, venue, poster, playwright, synopsis (excerpt), cast (or cast incomplete), crew (or crew incomplete) are missing from the show file. Erroneous 'and'
Still appears when show.ignore_missing is true (inherit behaviour of show_basic_details_missing
Caught some strange behaviours in existing shows.
Accidentally hid the synopsis, trivia and assets. Bad.
|
This PR is MASSIVE for about 6 commits. Squash, merge, and pick up where we left off in #1726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When missing many fields, suppress most of the boxes in favour of one big box, linking to a form.
For added flair, the form should be prefilled with the data we've already got, but that is currently beyond me.
Closes #641