add sidekiq_notice_only_once configuration to reduce noise from retriable sidekiq failures

[DonGiulio]

Overview

instrumentation for sidekiq, configures the server to call NewRelic::Agent.notice_error on any error that occurs, this means there will be a call also for each failed retry, generating a lot of noise.
(any temporary error that will be retried will be reported).

This can be annoying.

Adding sidekiq_notice_only_once configuration, by configuring it the user can decide not to report exceptions that will be retried, but only report an error on a job before it goes to the dead queue.
Thus reducing noise from temporary issues. (logging is advised)

Submitter Checklist:

• Include a link to the related GitHub issue, if applicable
• Add new tests for your change, if applicable

Testing

The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

Reviewer Checklist

• Perform code review
• Confirm all checks passed
• Open a separate PR to add a CHANGELOG entry

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ DonGiulio
❌ Giulio Giraldi

---

Giulio Giraldi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[kaylareopelle]

Hi @DonGiulio, thanks for opening this PR! Sorry to hear about the additional noise from the Sidekiq failures.

Before we release a change like this, we would like to add some tests for it. Would you be willing to write some tests?

Alternatively, our team can write tests. We don't have the capacity to do this at this time, but we can leave your PR open until we do.

[DonGiulio]

Hi @DonGiulio, thanks for opening this PR! Sorry to hear about the additional noise from the Sidekiq failures.

Before we release a change like this, we would like to add some tests for it. Would you be willing to write some tests?

Alternatively, our team can write tests. We don't have the capacity to do this at this time, but we can leave your PR open until we do.

Hello, Thanks for the feedback, I added some tests, I hope it's enough

[kaylareopelle]

Thank you! I'll take a look at the tests today. One other block on merging this PR is the CLA. Could you take a look at the CLA concerns for Giulio Giraldi? Let me know if there's anything we can do to help.

[DonGiulio]

Thank you! I'll take a look at the tests today. One other block on merging this PR is the CLA. Could you take a look at the CLA concerns for Giulio Giraldi? Let me know if there's anything we can do to help.

I'm having troubles approving the CLA, both committers are myself. I signed with one account, I seem unable to sign again with the different name, but same account. I'm happy to amend the author if you tell me what I should put there to be able to complete it

[kaylareopelle]

I'm having troubles approving the CLA, both committers are myself. I signed with one account, I seem unable to sign again with the different name, but same account. I'm happy to amend the author if you tell me what I should put there to be able to complete it

I took a look at the git logs for your branch and I think the problem is because the commits were made with two different email addresses. One with a gmail and the other with possibly a work email?

GitHub recognizes the gmail, but not the other email.

You could amend your commits to use a different author (I tried the suggestions in this post and they worked), add the second email to your GitHub account, or try to sign the CLA with the second email.