Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
b6a1a5d
Ruby 3.5.0-preview1 to PR Cont. Integration
hannahramadan Sep 11, 2025
0102d32
Add to gemspec
hannahramadan Sep 11, 2025
e01266d
Add 3.5 to unit
hannahramadan Sep 11, 2025
bfa5163
Add to test_helper
hannahramadan Sep 11, 2025
c916e08
remove logger from suite.rb
hannahramadan Sep 11, 2025
d53bc3f
add to dev depend
hannahramadan Sep 11, 2025
daf1afe
remove from gemspec
hannahramadan Sep 11, 2025
0977041
only dev depend
hannahramadan Sep 11, 2025
6cf72cb
pin logger in gemspec
hannahramadan Sep 11, 2025
0cee409
add to gemfile
hannahramadan Sep 11, 2025
659a0a8
ubuntu-latest
hannahramadan Sep 11, 2025
cfbe59d
install logger ci action
hannahramadan Sep 11, 2025
80cf6b2
test: gem install --default logger:1.7.0
hannahramadan Sep 11, 2025
c3c237b
install logger in setup_bundler
hannahramadan Sep 11, 2025
8c4292d
switch order
hannahramadan Sep 11, 2025
e1dab6f
gem list
hannahramadan Sep 11, 2025
953c4a3
gem --version
hannahramadan Sep 11, 2025
8b5a3d0
is rubygems messed?
hannahramadan Sep 11, 2025
6a83e97
add dash
hannahramadan Sep 11, 2025
8f5b9ac
check on bundle v
hannahramadan Sep 11, 2025
90877bb
bundler version test
hannahramadan Sep 11, 2025
6da582d
more logging!
hannahramadan Sep 11, 2025
4b58f73
force bundler uninstall
hannahramadan Sep 11, 2025
e76479a
fix!
hannahramadan Sep 11, 2025
8fef50b
NO LOGGER in setup
hannahramadan Sep 11, 2025
d0e9c8b
revert some changes/ remove logger from seetup
hannahramadan Sep 11, 2025
514e068
rubocop
hannahramadan Sep 11, 2025
8f3b465
rubocop
hannahramadan Sep 11, 2025
4238c01
add Benchmark to delayed_job suite
hannahramadan Sep 12, 2025
5583a3a
remove >3.5 check
hannahramadan Sep 12, 2025
5dbfa97
Add Benchmark to delayed_job test suite
hannahramadan Sep 15, 2025
9b7c6e8
Benchamrk
hannahramadan Sep 15, 2025
7833d02
Add benchmark to unit tests - rails envs
hannahramadan Sep 15, 2025
760334c
erb 5.0.2
hannahramadan Sep 15, 2025
bf9d11a
benchmark more places
hannahramadan Sep 15, 2025
50de844
more benchmark!
hannahramadan Sep 15, 2025
70aab7b
cleanups
hannahramadan Sep 15, 2025
eb2d5f2
add logger back
hannahramadan Sep 15, 2025
fe7bf3c
delayed job benchmark
hannahramadan Sep 15, 2025
978dd7c
swtich to dev depend
hannahramadan Sep 15, 2025
1773556
rubocop
hannahramadan Sep 15, 2025
4f8d66d
add back to depend gem
hannahramadan Sep 16, 2025
99e0dea
keep logger for older rubies
hannahramadan Sep 16, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/actions/run_unit_tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ runs:
},
"3.4.4": {
"rails": "norails,rails61,rails70,rails71,rails72,rails80,railsedge"
},
"3.5.0-preview1": {
"rails": "norails,rails61,rails70,rails71,rails72,rails80,railsedge"
}
}

Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # tag v5.0.0
- uses: ruby/setup-ruby@44511735964dcb71245e7e55f72539531f7bc0eb # tag v1.257.0
with:
ruby-version: 3.4
ruby-version: 3.5.0-preview1
- run: bundle
- run: rubocop

Expand All @@ -36,7 +36,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: [2.4.10, 3.4.4]
ruby-version: [2.4.10, 3.4.4, 3.5.0-preview1]
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
Expand All @@ -56,7 +56,7 @@ jobs:
fail-fast: false
matrix:
multiverse: [agent, ai, background, background_2, frameworks, httpclients, httpclients_2, hybrid_agent, rails, rest]
ruby-version: [2.4.10, 3.4.4]
ruby-version: [2.4.10, 3.4.4, 3.5.0-preview1]
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
Expand Down Expand Up @@ -89,7 +89,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: [2.4.10, 3.4.4]
ruby-version: [2.4.10, 3.4.4, 3.5.0-preview1]
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
Expand Down Expand Up @@ -139,7 +139,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: [2.4.10, 3.4.4]
ruby-version: [2.4.10, 3.4.4, 3.5.0-preview1]
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
Expand Down Expand Up @@ -182,7 +182,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: [2.4.10, 3.4.4]
ruby-version: [2.4.10, 3.4.4, 3.5.0-preview1]
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
Expand Down Expand Up @@ -229,7 +229,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: [2.4.10, 3.4.4]
ruby-version: [2.4.10, 3.4.4, 3.5.0-preview1]
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
Expand Down Expand Up @@ -268,7 +268,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: [2.4.10, 3.4.4]
ruby-version: [2.4.10, 3.4.4, 3.5.0-preview1]
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
Expand All @@ -287,7 +287,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: [2.7.8, 3.4.4]
ruby-version: [2.7.8, 3.4.4, 3.5.0-preview1]
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
Expand All @@ -312,7 +312,7 @@ jobs:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # tag v5.0.0
- uses: ruby/setup-ruby@44511735964dcb71245e7e55f72539531f7bc0eb # tag v1.257.0
with:
ruby-version: 3.4
ruby-version: 3.5.0-preview1
- run: bundle
- name: Download all workflow run artifacts
uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # tag v5.0.0
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/ci_cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # tag v5.0.0
- uses: ruby/setup-ruby@44511735964dcb71245e7e55f72539531f7bc0eb # tag v1.257.0
with:
ruby-version: 3.4
ruby-version: 3.5.0-preview1
- run: bundle
- run: rubocop

Expand All @@ -36,7 +36,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: [2.4.10, 2.5.9, 2.6.10, 2.7.8, 3.0.7, 3.1.7, 3.2.8, 3.3.8, 3.4.4]
ruby-version: [2.4.10, 2.5.9, 2.6.10, 2.7.8, 3.0.7, 3.1.7, 3.2.8, 3.3.8, 3.4.4, 3.5.0-preview1]
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
Expand All @@ -54,7 +54,7 @@ jobs:
fail-fast: false
matrix:
multiverse: [agent, ai, background, background_2, frameworks, httpclients, httpclients_2, hybrid_agent, rails, rest]
ruby-version: [2.4.10, 2.5.9, 2.6.10, 2.7.8, 3.0.7, 3.1.7, 3.2.8, 3.3.8, 3.4.4]
ruby-version: [2.4.10, 2.5.9, 2.6.10, 2.7.8, 3.0.7, 3.1.7, 3.2.8, 3.3.8, 3.4.4, 3.5.0-preview1]
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: [2.4.10, 2.5.9, 2.6.10, 2.7.8, 3.0.7, 3.1.7, 3.2.8, 3.3.8, 3.4.4]
ruby-version: [2.4.10, 2.5.9, 2.6.10, 2.7.8, 3.0.7, 3.1.7, 3.2.8, 3.3.8, 3.4.4, 3.5.0-preview1]
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
Expand Down Expand Up @@ -139,7 +139,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: [2.4.10, 2.5.9, 2.6.10, 2.7.8, 3.0.7, 3.1.7, 3.2.8, 3.3.8, 3.4.4]
ruby-version: [2.4.10, 2.5.9, 2.6.10, 2.7.8, 3.0.7, 3.1.7, 3.2.8, 3.3.8, 3.4.4, 3.5.0-preview1]
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: [2.5.9, 2.6.10, 2.7.8, 3.0.7, 3.1.7, 3.2.8, 3.3.8, 3.4.4]
ruby-version: [2.5.9, 2.6.10, 2.7.8, 3.0.7, 3.1.7, 3.2.8, 3.3.8, 3.4.4, 3.5.0-preview1]
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
Expand Down Expand Up @@ -231,7 +231,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: [2.4.10, 2.5.9, 2.6.10, 2.7.8, 3.0.7, 3.1.7, 3.2.8, 3.3.8, 3.4.4]
ruby-version: [2.4.10, 2.5.9, 2.6.10, 2.7.8, 3.0.7, 3.1.7, 3.2.8, 3.3.8, 3.4.4, 3.5.0-preview1]
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
Expand Down Expand Up @@ -271,7 +271,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: [2.4.10, 2.5.9, 2.6.10, 2.7.8, 3.0.7, 3.1.7, 3.2.8, 3.3.8, 3.4.4]
ruby-version: [2.4.10, 2.5.9, 2.6.10, 2.7.8, 3.0.7, 3.1.7, 3.2.8, 3.3.8, 3.4.4, 3.5.0-preview1]
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
Expand All @@ -290,7 +290,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: [2.7.8, 3.0.7, 3.1.7, 3.2.8, 3.3.8, 3.4.4]
ruby-version: [2.7.8, 3.0.7, 3.1.7, 3.2.8, 3.3.8, 3.4.4, 3.5.0-preview1]
steps:
- name: Configure git
run: 'git config --global init.defaultBranch main'
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/scripts/setup_bundler
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,18 @@ function install_ruby_version_specific_gems {
gem install --default digest:3.1.0
gem install --default digest:3.2.0
gem install --default erb:4.0.4
gem install --default erb:5.0.1
gem install --default logger:1.7.0
gem install --default erb:5.0.2

gem install --default securerandom:0.3.2
gem install --default securerandom:0.4.1
gem install --default set:1.1.2
gem install --default strscan:3.0.4
gem install --default strscan:3.1.5

if [[ $RUBY_VERSION =~ ^(2\.|3\.[0-4]) ]]; then
gem install --default logger:1.7.0
fi

echo "DEBUG: Completed installing gems"

}
Expand Down
2 changes: 2 additions & 0 deletions newrelic_rpm.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ Gem::Specification.new do |s|
s.require_paths = ['lib']
s.summary = 'New Relic Ruby Agent'

s.add_dependency 'logger'

s.add_development_dependency 'bundler'
s.add_development_dependency 'feedjira', '3.2.1' unless ENV['CI'] || RUBY_VERSION < '2.5' # for Gabby
s.add_development_dependency 'httparty' unless ENV['CI'] # for perf tests and Gabby
Expand Down
1 change: 1 addition & 0 deletions test/environments/rails61/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ if RUBY_VERSION.split('.')[0..1].join('.').to_f >= 3.4
gem 'bigdecimal'
gem 'mutex_m'
gem 'ostruct'
gem 'benchmark'
end

gem 'logger'
1 change: 1 addition & 0 deletions test/environments/rails70/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@ if RUBY_VERSION.split('.')[0..1].join('.').to_f >= 3.4
gem 'bigdecimal'
gem 'mutex_m'
gem 'ostruct'
gem 'benchmark'
end
gem 'logger'
1 change: 1 addition & 0 deletions test/environments/rails71/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@ if RUBY_VERSION.split('.')[0..1].join('.').to_f >= 3.4
gem 'bigdecimal'
gem 'mutex_m'
gem 'ostruct'
gem 'benchmark'
end
gem 'logger'
1 change: 1 addition & 0 deletions test/environments/rails72/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@ if RUBY_VERSION.split('.')[0..1].join('.').to_f >= 3.4
gem 'bigdecimal'
gem 'mutex_m'
gem 'ostruct'
gem 'benchmark'
end
gem 'logger'
1 change: 1 addition & 0 deletions test/environments/rails80/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@ if RUBY_VERSION.split('.')[0..1].join('.').to_f >= 3.4
gem 'bigdecimal'
gem 'mutex_m'
gem 'ostruct'
gem 'benchmark'
end
gem 'logger'
1 change: 1 addition & 0 deletions test/environments/railsedge/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@ if RUBY_VERSION.split('.')[0..1].join('.').to_f >= 3.4
gem 'bigdecimal'
gem 'mutex_m'
gem 'ostruct'
gem 'benchmark'
end
gem 'logger'
1 change: 1 addition & 0 deletions test/multiverse/suites/active_record_pg/Envfile
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ def gem_list(activerecord_version = nil)

gem 'rack'
gem 'minitest', '~> 5.2.3'
gem 'benchmark' if RUBY_VERSION >= '3.5.0'
RB
end

Expand Down
2 changes: 1 addition & 1 deletion test/multiverse/suites/capistrano2/Envfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ end
gemfile <<~RB
gem 'capistrano', '~> 2.15.5'
gem 'rack'

gem 'benchmark' if RUBY_VERSION >= '3.5.0'
RB
1 change: 1 addition & 0 deletions test/multiverse/suites/delayed_job/Envfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ end

boilerplate_gems = <<~SQLITE
gem 'rack'
gem 'benchmark'
#{sqlite}
#{bigdecimal}

Expand Down
1 change: 1 addition & 0 deletions test/multiverse/suites/rails/Envfile
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ def gem_list(rails_version = nil)
gem 'erubis' if RUBY_PLATFORM.eql?('java')
gem 'loofah', '~> 2.20.0' if RUBY_VERSION >= '2.4.0' && RUBY_VERSION < '2.5.0'
gem 'drb' if RUBY_VERSION >= '3.4.0'
gem 'benchmark' if RUBY_VERSION >= '3.5.0'
RB
end

Expand Down
1 change: 1 addition & 0 deletions test/multiverse/suites/rails_prepend/Envfile
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ def gem_list(rails_version = nil)
#{thor}
gem 'loofah', '~> 2.20.0' if RUBY_VERSION >= '2.4.0' && RUBY_VERSION < '2.5.0'
gem 'drb' if RUBY_VERSION >= '3.4.0'
gem 'benchmark' if RUBY_VERSION >= '3.5.0'
RB
end

Expand Down
Loading