Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable log forwarding by default. #587

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Conversation

umaannamalai
Copy link
Contributor

This PR enables log forwarding by default and corrects the Python agent data usage supportability metric naming scheme. It also addresses a bug related to compressed byte calculation.

umaannamalai and others added 2 commits July 20, 2022 15:11
* Enable log forwarding by default.

* Fix catmap fixture for log forwarding compatibility.

* Use isinstance check in fixtures.
* Update data usage supportability metric name.

* Fix compression bug and add testing.

Co-authored-by: Lalleh Rafeei <[email protected]>
Co-authored-by: Nyenty Ayuk-Enow <[email protected]>

* Update harvest_loop tests.

* Update compression test to check method1 payload length for consistency.

Co-authored-by: Lalleh Rafeei <[email protected]>
Co-authored-by: Nyenty Ayuk-Enow <[email protected]>
@umaannamalai umaannamalai requested a review from a team July 21, 2022 16:18
@github-actions
Copy link

MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ PYTHON bandit 5 1 1.15s
✅ PYTHON black 5 4 0 4.49s
✅ PYTHON flake8 5 0 1.25s
✅ PYTHON isort 5 4 0 0.24s
❌ PYTHON pylint 5 81 9.61s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@lrafeei lrafeei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lrafeei lrafeei merged commit cd23f56 into main Jul 21, 2022
@lrafeei lrafeei deleted the develop-logging-on-by-default branch July 21, 2022 16:56
@lrafeei lrafeei added this to the v7.16.0.178 milestone Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants