Skip to content

Conversation

@hmstepanek
Copy link
Contributor

@hmstepanek hmstepanek commented Dec 13, 2025

Overview

  • Add fragmentation tracking metric for when we run out of space to add more nr.ids in compact mode.
  • Add nr.pg to entry span to track when a transaction is partial granularity.
  • Keep error attributes on partial granularity spans.
  • Only record partial granularity type supportability metric if partial granularity transactions are actually sent.
  • Small fixup to logic to make it more clear (not a==b => a!=b).

@hmstepanek hmstepanek requested a review from a team as a code owner December 13, 2025 01:17
@hmstepanek hmstepanek changed the base branch from main to develop-hybrid-core-tracing December 13, 2025 01:17
@hmstepanek hmstepanek force-pushed the add-error-attr-support branch from 29ea8dd to dca5328 Compare December 13, 2025 01:18
@github-actions
Copy link

github-actions bot commented Dec 13, 2025

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 7 0 0 0.93s
✅ MARKDOWN markdownlint 7 0 0 0 1.35s
✅ PYTHON ruff 970 1 0 0 0.99s
✅ PYTHON ruff-format 970 3 0 0 0.39s
✅ YAML prettier 15 0 0 0 1.46s
✅ YAML v8r 15 0 0 6.15s
✅ YAML yamllint 15 0 0 0.69s

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security

@hmstepanek hmstepanek changed the title Keep error attributes on partial granularity spans. Add attributes to partial granularity spans & tracking metrics Dec 13, 2025
@hmstepanek hmstepanek changed the title Add attributes to partial granularity spans & tracking metrics Add attrs to partial gran spans & tracking metrics Dec 13, 2025
@mergify mergify bot added the tests-failing Tests failing in CI. label Dec 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2025

Codecov Report

❌ Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop-hybrid-core-tracing@378c2c6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
newrelic/core/node_mixin.py 0.00% 10 Missing and 1 partial ⚠️
newrelic/api/transaction.py 0.00% 1 Missing ⚠️
newrelic/core/transaction_node.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##             develop-hybrid-core-tracing    #1608   +/-   ##
==============================================================
  Coverage                               ?   73.56%           
==============================================================
  Files                                  ?      213           
  Lines                                  ?    25018           
  Branches                               ?     3970           
==============================================================
  Hits                                   ?    18404           
  Misses                                 ?     5057           
  Partials                               ?     1557           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-failing Tests failing in CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants