Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendMetric defaulted to true #175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

sendMetric defaulted to true #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90cb217
feat: Changed sendMetric defaulted by true
voorepreethi Jan 31, 2025
5f699de
Update config.go
voorepreethi Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ The plugin supports the following configuration parameters (apart from the ones
| caBundleFile | **[LINUX HTTPS ONLY]** Specifies the Certificate Authority certificate to use for validating HTTPS connections against the proxy. Useful when the proxy uses a self-signed certificate. **The certificate file must be in the PEM format**. If not specified, then the operating system's CA list is used. Only used when `validateProxyCerts` is `true`. | (none) |
| caBundleDir | **[LINUX HTTPS ONLY]** Specifies a folder containing one or more Certificate Authority certificates ot use for validating HTTPS connections against the proxy. Useful when the proxy uses a self-signed certificate. **Only certificate files in the PEM format and \*.pem extension will be considered**. If not specified, then the operating system's CA list is used. Only used when `validateProxyCerts` is `true`. | (none) |
| validateProxyCerts | **[HTTPS ONLY]** When using a HTTPS proxy, the proxy certificates are validated by default when establishing a HTTPS connection. To disable the proxy certificate validation, set `validateProxyCerts` to `false` (insecure) | true |
| sendMetrics | Set to true to send plugin troubleshoot metrics to the Metrics event type. Please see [this section](#troubleshooting-metrics) for more details | false |
| sendMetrics | Set to true to send plugin troubleshoot metrics to the Metrics event type. Please see [this section](#troubleshooting-metrics) for more details | true |

#### Proxy support

Expand Down
2 changes: 1 addition & 1 deletion config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func parseNRClientConfig(ctx unsafe.Pointer) (cfg NRClientConfig, err error) {

cfg.TimeoutSeconds, err = optInt(ctx, "httpClientTimeout", 5)

cfg.SendMetrics, err = optBool(ctx, "sendMetrics", false)
cfg.SendMetrics, err = optBool(ctx, "sendMetrics", true)

return
}
Expand Down
Loading