-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove FID, replace first interaction detection with INP #1395
Conversation
Preserve `firstInteraction` by detecting the first INP instead of FID event.
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
==========================================
- Coverage 88.67% 88.67% -0.01%
==========================================
Files 170 169 -1
Lines 7416 7406 -10
Branches 1503 1500 -3
==========================================
- Hits 6576 6567 -9
Misses 732 732
+ Partials 108 107 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Can you change the PR title to something more specific for the changelog/release notes |
re-testing after branch updates, will approve with passing tests |
First Input Delay (FID) has been deprecated and replaced by Interaction To Next Paint (INP). PageViewTiming events for first interactions are preserved by detecting the first INP event and will no longer output value for the
firstInputDelay
attribute. For more info on PageViewTiming, see https://docs.newrelic.com/docs/browser/new-relic-browser/page-load-timing-resources/pageviewtiming-async-or-dynamic-page-details/. For more info on INP and the FID deprecation, see https://web.dev/articles/inp.Overview
In this PR, we are proceeding with the removal of FID related logic from the browser agent.
Notes:
The
firstInteraction
timing event should continue to be detected as-is, with the following differences:firstInputDelay
attribute will no longer be generatedvisibilityChange
=hidden
interactionType
values:Supported in Chrome, Edge, and Android. Not supported on Firefox, Safari and iOS (see PerformanceEventTming browser compatibility)
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-365650
Testing
Updated existing tests that dealt with FID.
Added unit tests for first interaction.
Manually tested