Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Support experiment uploads without deploy to internal site #1344

Merged
merged 6 commits into from
Feb 13, 2025

Conversation

ptang-nr
Copy link
Contributor

Modify the existing publish-experiment workflow to support uploading experiments without deploying to internal site. This will come in handy for cases where we may wish to make experimental builds available on the CDN, to be used outside of internal experiments.

Overview

Related Issue(s)

Testing

Copy link

github-actions bot commented Jan 24, 2025

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.89 kB / 11.21 kB (gzip) 30.89 kB / 11.21 kB (gzip) 0% / 0% (gzip)
lite async-chunk 53.61 kB / 17.47 kB (gzip) 53.61 kB / 17.47 kB (gzip) 0% / 0% (gzip)
pro loader 52.58 kB / 18.16 kB (gzip) 52.58 kB / 18.16 kB (gzip) 0% / 0% (gzip)
pro async-chunk 101.31 kB / 31.02 kB (gzip) 101.31 kB / 31.02 kB (gzip) 0% / 0% (gzip)
spa loader 60.2 kB / 20.47 kB (gzip) 60.2 kB / 20.47 kB (gzip) 0% / 0% (gzip)
spa async-chunk 116.02 kB / 35.35 kB (gzip) 116.02 kB / 35.35 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.90%. Comparing base (a92b557) to head (1a9452b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1344   +/-   ##
=======================================
  Coverage   88.90%   88.90%           
=======================================
  Files         170      170           
  Lines        7366     7366           
  Branches     1488     1488           
=======================================
  Hits         6549     6549           
  Misses        711      711           
  Partials      106      106           
Flag Coverage Δ
unit-tests 79.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metal-messiah
Copy link
Member

I think this PR will need to update publish-dev to also consider if the experiment was meant to make it to NR1. Wait to merge this until more validation is done

@metal-messiah
Copy link
Member

I think this PR will need to update publish-dev to also consider if the experiment was meant to make it to NR1. Wait to merge this until more validation is done

To expand on this, when publish-dev runs automatically on merges to main, it will check the experiments folder and upload them to the a/b script still. I think the standalone experiments like this need to go to a new directory in S3

Experiments uploaded to the `dev` or `staging` folders will be automatically incorporated in the corresponding `<env>-experiments.js` build.
@ptang-nr ptang-nr merged commit 3222bad into main Feb 13, 2025
17 checks passed
@ptang-nr ptang-nr deleted the add-option-to-only-upload-experiment branch February 13, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants