-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Support experiment uploads without deploy to internal site #1344
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1344 +/- ##
=======================================
Coverage 88.90% 88.90%
=======================================
Files 170 170
Lines 7366 7366
Branches 1488 1488
=======================================
Hits 6549 6549
Misses 711 711
Partials 106 106
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think this PR will need to update |
To expand on this, when |
Experiments uploaded to the `dev` or `staging` folders will be automatically incorporated in the corresponding `<env>-experiments.js` build.
Modify the existing
publish-experiment
workflow to support uploading experiments without deploying to internal site. This will come in handy for cases where we may wish to make experimental builds available on the CDN, to be used outside of internal experiments.Overview
Related Issue(s)
Testing