Skip to content

Commit

Permalink
Post Test PR Cleanup (#146)
Browse files Browse the repository at this point in the history
* Remove Go agent from codeowners

* Fix broken Makefile scripting for yq
  • Loading branch information
TimPansino authored Feb 3, 2025
1 parent 87de9d1 commit fccef69
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 10 deletions.
6 changes: 1 addition & 5 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
# Default permissions for all files not matched below
* @newrelic/dotnet @newrelic/go @newrelic/java @newrelic/node @newrelic/phpc @newrelic/python @newrelic/ruby
* @newrelic/dotnet @newrelic/java @newrelic/node @newrelic/phpc @newrelic/python @newrelic/ruby

# Team based ownership
/.github/workflows/dotnet.yml @newrelic/dotnet
/src/dotnet/ @newrelic/dotnet
/tests/dotnet/ @newrelic/dotnet

/.github/workflows/go.yml @newrelic/go
/src/go/ @newrelic/go
/tests/go/ @newrelic/go

/.github/workflows/java.yml @newrelic/java
/src/java/ @newrelic/java
/tests/java/ @newrelic/java
Expand Down
11 changes: 6 additions & 5 deletions tests/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,12 @@ test: build-initcontainer build-testapp check-language-arg
@sleep 5
@kubectl wait --for=condition=Ready -n default --all pods
# If yq is installed, check for the initcontainer to be visible on the pod spec
@which -s yq && \
echo "===== Ensuring initcontainer was successfully attached by operator. ====="; \
kubectl get pods --output yaml | yq '.items[].spec.initContainers[].name' | grep -q "newrelic-instrumentation-" \
&& echo "===== Initcontainer successfully attached. =====" \
|| { echo -e "===== Operator failed to attach initcontainer. =====" >&2; exit 1; }
@echo "===== Ensuring initcontainer was successfully attached by operator. =====" && \
which -s yq && { \
kubectl get pods --output yaml | yq '.items[].spec.initContainers[].name' | grep -q "newrelic-instrumentation-" \
&& echo "===== Initcontainer successfully attached. =====" \
|| { echo -e "===== Operator failed to attach initcontainer. =====" >&2; exit 1; } } \
|| echo "yq is not installed. Skipping."
@echo "===== Opening tunnel to test app and opening web browser. ====="
@minikube service test-app-${INITCONTAINER_LANGUAGE}-service -n default

Expand Down

0 comments on commit fccef69

Please sign in to comment.