Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NR-347440] CFN template validate lambda integration logs #17

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

ahegdeNR
Copy link
Contributor

As part of this pr:

Create events in lambda from s3 and cloudwatch
Validate that logs are getting populated in New Relic on event creation.
Create scripts to fetch and validate logs in New Relic.

@ahegdeNR ahegdeNR self-assigned this Jan 15, 2025
e2e-tests/common-scripts.sh Outdated Show resolved Hide resolved
e2e-tests/common-scripts.sh Outdated Show resolved Hide resolved
.github/workflows/run-e2e-tests.yaml Outdated Show resolved Hide resolved
e2e-tests/common-scripts/logs-scripts.sh Show resolved Hide resolved
e2e-tests/common-scripts/logs-scripts.sh Outdated Show resolved Hide resolved
e2e-tests/lambda-cloudwatch-trigger.sh Show resolved Hide resolved
e2e-tests/lambda-cloudwatch-trigger.sh Show resolved Hide resolved
@hrai-nr
Copy link
Contributor

hrai-nr commented Jan 22, 2025

  1. Test cases for entity synthesis params are missing.
  2. Please add the slack notification code.

@ahegdeNR ahegdeNR requested a review from hrai-nr January 29, 2025 08:56
Copy link
Contributor

@hrai-nr hrai-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are looking fine, but code to send notification to slack channel is missing, please add that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants