Extract interfaces for testability in control and orchestration packages #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create feedback.Processor interface in internal/feedback/interface.go with DefaultProcessor implementation wrapping ProcessPRFeedbackQuiet - Create ControlPlane struct in internal/control/plane.go with: - git.Operations, worktree.Operations, zellij.SessionManager - mise.Operations factory, feedback.Processor - OrchestratorSpawner and WorkDestroyer interfaces - NewControlPlane() with defaults, NewControlPlaneWithDeps() for testing - Update loop.go to use ControlPlane with RunControlPlaneLoopWithControlPlane and ProcessAllDueTasksWithControlPlane for testing This enables unit testing of control plane tasks without external dependencies (CLI tools, services, file system operations). Closes: ac-a7av, ac-a7av.1, ac-a7av.2 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Delete standalone handler functions that are now implemented as methods on ControlPlane in plane.go: - handler_create_worktree.go - handler_spawn_orchestrator.go - handler_pr_feedback.go - handler_git_push.go - handler_destroy_worktree.go Co-Authored-By: Claude Opus 4.5 <[email protected]>
Keep handlers in their original files to minimize PR diff churn. The handlers are now methods on ControlPlane using injected dependencies instead of standalone functions creating instances. Also make processPRFeedbackQuiet internal since it's only used within the feedback package. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Revert unnecessary variable renames and comment changes to keep the diff focused on the actual interface extraction changes. Co-Authored-By: Claude Opus 4.5 <[email protected]>
newhook
deleted the
feat/extract-interfaces-for-testability-in-control-and
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts interfaces and refactors the control package to enable unit testing without external dependencies (CLI tools, services, file system operations).
Changes
Created
ControlPlanestruct with dependency injection (internal/control/plane.go)git.Operations,worktree.Operations,zellij.SessionManager,mise.Operations,feedback.ProcessorOrchestratorSpawnerandWorkDestroyerinterfaces for additional abstractionNewControlPlane()constructor with production defaultsNewControlPlaneWithDeps()constructor for testing with mock dependenciesControlPlaneExtracted
feedback.Processorinterface (internal/feedback/interface.go)ProcessPRFeedback()method for abstracting PR feedback processingDefaultProcessorimplementation that wraps existingProcessPRFeedbackQuiet()functionUpdated control loop (
internal/control/loop.go)RunControlPlaneLoopWithControlPlane()for testing with injected dependenciesProcessAllDueTasksWithControlPlane()for testingControlPlane.GetTaskHandlers()Removed orphaned handler files
handler_create_worktree.go- nowControlPlane.HandleCreateWorktreeTask()handler_spawn_orchestrator.go- nowControlPlane.HandleSpawnOrchestratorTask()handler_pr_feedback.go- nowControlPlane.HandlePRFeedbackTask()handler_git_push.go- nowControlPlane.HandleGitPushTask()handler_destroy_worktree.go- nowControlPlane.HandleDestroyWorktreeTask()Issues Resolved
Breaking Changes
None. The public API remains unchanged -
RunControlPlaneLoop()andProcessAllDueTasks()continue to work with default production dependencies.Test Plan
go buildsucceedsgo test ./...🤖 Generated with Claude Code