Extract interfaces for testability in CLI wrapper packages #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add worktree.Operations interface with cliOperations implementation - Add claude.Runner interface with cliRunner implementation - Add linear.ClientInterface with compile-time check - Add NewFetcherWithClient constructor for testing with mock clients - All interfaces follow established patterns from git.go, mise.go, zellij.go - Backwards compatible: package-level functions delegate to Default Co-Authored-By: Claude Opus 4.5 <[email protected]>
Replace global Default variable and Run convenience function with explicit NewRunner() constructor. Callers now create Runner instances directly, eliminating hidden global state and making dependencies clearer. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Pass claude.Runner as a parameter to processTask and executeTask functions, enabling mock injection for testing. Runner is created once at the entry point and passed down the call chain. Co-Authored-By: Claude Opus 4.5 <[email protected]>
…ages Replace global Default variables and convenience functions with explicit NewOperations() constructors. Callers now create Operations instances directly, eliminating hidden global state. - git: Remove Default, PushSetUpstreamInDir, PullInDir, Clone, FetchBranch, BranchExists, ValidateExistingBranch, ListBranches convenience functions - worktree: Remove Default, Create, CreateFromExisting, RemoveForce, List, ExistsPath convenience functions - Update all callers to use NewOperations() pattern Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Explicitly ignore errors from wtOps.RemoveForce cleanup operations - Fixes errcheck linter violations at lines 320, 340, 359, and 366 - Uses _ = pattern to indicate intentional error ignoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts interfaces from packages that directly call external CLIs or HTTP APIs, enabling unit testing without external dependencies. Callers explicitly create instances via constructors and pass them as parameters for dependency injection.
Changes
internal/worktree/worktree.goOperationsinterface with methods:Create,CreateFromExisting,RemoveForce,List,ExistsPathCLIOperationsstruct implementing the interfaceNewOperations()constructor for creating instancesinternal/git/git.goOperationsinterface with methods:PushSetUpstream,Pull,Clone,FetchBranch,BranchExists,ValidateExistingBranch,ListBranchesCLIOperationsstruct implementing the interfaceNewOperations()constructor for creating instancesinternal/claude/inline.goRunnerinterface withRunmethodCLIRunnerstruct implementing the interfaceNewRunner()constructor for creating instancesprocessTaskandexecuteTaskacceptRunnerparameter for injectioninternal/linear/client.goClientInterfacewith methods:GetIssue,SearchIssues,ListIssues,GetIssueCommentsClientimplementsClientInterfaceinternal/linear/fetcher.goFetcher.clientfield type from*ClienttoClientInterfaceNewFetcherWithClientconstructor for injecting mock clients in testsDesign Decisions
Defaultvariables and package-level convenience functionsvar _ Interface = (*impl)(nil)Issues Resolved
Test Plan
🤖 Generated with Claude Code