Extract interfaces for testability in CLI wrapper packages #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Define Operations interface with 7 methods (PushSetUpstream, Pull, Clone, FetchBranch, BranchExists, ValidateExistingBranch, ListBranches) - Create cliOperations struct implementing the interface - Add Default variable for production use - Keep existing functions as wrappers for backward compatibility Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Define Operations interface with 8 methods (IsManaged, Trust, Install, HasTask, RunTask, Exec, Initialize, InitializeWithOutput) - Create cliOperations struct implementing the interface - Add Default variable for production use - Keep existing functions as wrappers for backward compatibility Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Define ClientInterface with 6 methods (GetPRStatus, PostPRComment, PostReplyToComment, PostReviewReply, ResolveReviewThread, GetJobLogs) - Add compile-time check that Client implements ClientInterface - Update internal/feedback to accept interface instead of *Client Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Define ClientInterface covering session, tab, and pane operations - Add compile-time check that Client implements ClientInterface - Update internal/tui to accept interface instead of *Client Co-Authored-By: Claude Opus 4.5 <[email protected]>
Created cli.go with: - CLI interface for bd command operations (Init, InstallHooks, Create, Close, Reopen, Update, AddComment, AddLabels, SetExternalRef, AddDependency) - Reader interface for database queries (GetBead, GetBeadsWithDeps, ListBeads, GetReadyBeads, GetTransitiveDependencies, GetBeadWithChildren) - cliImpl struct implementing CLI using the bd command - DefaultCLI variable for the default implementation - Compile-time check that Client implements Reader Co-Authored-By: Claude Opus 4.5 <[email protected]>
Move beadsDir from method parameters to struct field, matching the Reader/Client pattern. Init and InstallHooks remain package-level functions as they're setup operations. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Move dir from method parameters to struct field, matching the beads CLI pattern. Package-level functions remain for convenience. Co-Authored-By: Claude Opus 4.5 <[email protected]>
SessionManager handles session lifecycle (list, create, delete). Session is bound to a specific session name and handles tabs, panes, and input operations without repeating the session parameter. ClientInterface remains for backward compatibility, embedding both. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Callers now use m.zj.Session(session).Method() pattern instead of passing session to each method call. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds interfaces to packages that wrap external CLI tools (git, mise, github, zellij, beads) to enable unit testing without external dependencies. Each package now has a testable interface that can be mocked in tests.
Changes
internal/git
Operationsinterface with 7 methods:PushSetUpstream,Pull,Clone,FetchBranch,BranchExists,ValidateExistingBranch,ListBranchescliOperationsstruct implementing the interfaceDefaultvariable for the standard implementationinternal/mise
Operationsinterface with 8 methods:IsManaged,Trust,Install,HasTask,RunTask,Exec,Initialize,InitializeWithOutputcliOperationsstruct implementing the interfaceDefaultvariable for the standard implementationinternal/github
ClientInterfacewith 6 methods:GetPRStatus,PostPRComment,PostReplyToComment,PostReviewReply,ResolveReviewThread,GetJobLogs*ClientimplementsClientInterfaceinternal/feedbackto use interface instead of concrete typeinternal/zellij
ClientInterfacecovering all session, tab, and pane operations (25 methods)*ClientimplementsClientInterfaceinternal/tui/tui_plan.goto use interfaceinternal/beads (new file: cli.go)
CLIinterface for bd command operations:Init,InstallHooks,Create,Close,Reopen,Update,AddComment,AddLabels,SetExternalRef,AddDependencyReaderinterface for database queries:GetBead,GetBeadsWithDeps,ListBeads,GetReadyBeads,GetTransitiveDependencies,GetBeadWithChildrencliImplstruct withDefaultCLIvariable*ClientimplementsReaderIssues Resolved
Testing
Notes
git.Default,mise.Default,beads.DefaultCLI)🤖 Generated with Claude Code