Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XKit Preferences: Improve error UI #2177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcustyphoon
Copy link

This improves the UI shown in the XKit preference pane when there is an error accessing a script's data. Specifically, it fixes the title being "undefined" in certain circumstances, removes a backdrop element that made the text basically unreadable, and adds a button to force update extensions to fix the problem.

This is generally hard to encounter in practice (for this screenshot I ran browser.storage.local.remove('extension_old_blue') using Chrome's console's ability to run arbitrary code in the content script sandbox, which is very convenient). But it's an edge case that will come up if in a future version we execute scripts directly out of the extension package and don't save them to storage, but a user downgrades back to the current or a prior version... or, naturally, if you are a developer and are switching back and forth between branches that do and do not do this.

This should be copied into the 7.9.2 branch as well (note: copy the whole xkit_preferences.js and xkit_preferences.css files rather than cherry picking).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant