Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release actions #2155

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

marcustyphoon
Copy link

@marcustyphoon marcustyphoon commented Nov 14, 2024

This creates a Github action that, when manually run after a version bump, submits the extension for Firefox review and signing and (if the prior step doesn't time out) drafts a prefilled Github release with the returned signed xpi file attached, pointing to a (nonexistent-until-published) tag named for the new version.

This also creates a Github action that, when manually run, downloads the latest signed xpi file from Mozilla, checks that it corresponds to the current version, and drafts the same Github release as above if so. In the case where Mozilla's review takes too long and the former action times out, this can do the job of the rest of it.

It should be quite simple to add Chrome web store upload to these using chrome-webstore-upload-cli; it just requires some API keys. I'm not sure how the timeline works, though, re: upload-vs-review-vs-publish.

Note that:

  • This isn't fully tested; there's only so much you can do without proper API access. Example result with some mocked APIs: https://github.com/marcustyphoon/XKit/releases/tag/v7.10.1
  • I don't know if the XPI files that get returned from AMO have UUIDs in the names. If so, this needs a rename step.
  • Version bumping web-ext probably breaks the other web-ext action.

Copy link

@hobinjk hobinjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Not too big a fan of js-in-yaml as a concept but it's definitely okay for the snippets here

@marcustyphoon
Copy link
Author

Yeah, I'm not a big fan either. It seemed like a nice alternative to some bash oneliner stuff I was doing at one point (cat manifest.json | jq -r '.version') but it became not-really-close-to-a-oneliner. We can maybe pop it out into a js file later.

@marcustyphoon marcustyphoon merged commit d2e56bc into new-xkit:master Nov 22, 2024
1 check passed
marcustyphoon added a commit to marcustyphoon/XKit that referenced this pull request Dec 2, 2024
commit 43e5e17
Author: marcustyphoon <[email protected]>
Date:   Sun Dec 1 17:24:57 2024 -0800

    Fix gh-pages workflow (master branch) (new-xkit#2170)

commit bb16651
Author: marcustyphoon <[email protected]>
Date:   Sun Dec 1 13:15:26 2024 -0800

    Move 7.9.2 patches into 7.10.0 xkit.js (new-xkit#2165)

commit ee9ab3e
Author: marcustyphoon <[email protected]>
Date:   Sat Nov 23 20:58:57 2024 -0800

    Release action: fix XPI download step (new-xkit#2164)

commit d2e56bc
Author: marcustyphoon <[email protected]>
Date:   Fri Nov 22 11:45:25 2024 -0800

    Add release actions (new-xkit#2155)

commit a305a37
Author: marcustyphoon <[email protected]>
Date:   Fri Nov 22 11:20:28 2024 -0800

    7.10.0 xkit patches version bump (new-xkit#2161)

commit 900076f
Author: marcustyphoon <[email protected]>
Date:   Fri Nov 22 10:24:11 2024 -0800

    Add 7.9.2 deployment workflow (new-xkit#2159)

commit a1e6fd6
Author: marcustyphoon <[email protected]>
Date:   Sun Nov 17 10:11:02 2024 -0800

    Update CI action (new-xkit#2156)

commit 9d175f6
Author: marcustyphoon <[email protected]>
Date:   Sun Nov 17 10:10:41 2024 -0800

    Add release metadata action (new-xkit#2153)

commit 3d5f273
Author: marcustyphoon <[email protected]>
Date:   Sun Nov 17 10:09:42 2024 -0800

    Clean up more whitespace (new-xkit#2152)

commit d4a8db0
Merge: da64504 965f1c9
Author: marcustyphoon <[email protected]>
Date:   Sat Nov 16 11:45:29 2024 -0800

    Package code with extension (new-xkit#2148)

commit 965f1c9
Author: Marcus <[email protected]>
Date:   Wed Nov 13 17:06:31 2024 -0800

    add npm cache to action

commit cc385e8
Author: Marcus <[email protected]>
Date:   Tue Nov 5 18:03:21 2024 -0800

    don't fetch invalid resources

commit 4568328
Author: Marcus <[email protected]>
Date:   Tue Nov 5 17:01:57 2024 -0800

    Update .eslintrc.yml

commit 0103bc6
Author: Marcus <[email protected]>
Date:   Tue Nov 5 17:01:52 2024 -0800

    commit index build script

commit d574831
Author: Marcus <[email protected]>
Date:   Tue Oct 22 04:52:47 2024 -0700

    add caching to getExtensionData

commit 7d5d32e
Author: Marcus <[email protected]>
Date:   Mon Oct 21 21:36:21 2024 -0700

    don't remove run_order entries (for downgrade compat)

commit adfd409
Author: Marcus <[email protected]>
Date:   Thu Oct 10 14:52:32 2024 -0700

    add back pages workflow

commit 41e82fc
Author: Marcus <[email protected]>
Date:   Thu Oct 10 15:25:17 2024 -0700

    bump script versions

commit b3fe374
Author: Marcus <[email protected]>
Date:   Wed Oct 9 21:18:56 2024 -0700

    bump version

commit 9bede3b
Author: Marcus <[email protected]>
Date:   Thu Oct 10 01:36:22 2024 -0700

    check updates immediately

commit e7f81db
Author: Marcus <[email protected]>
Date:   Wed Oct 9 21:56:51 2024 -0700

    remove gulp server

commit 48a8a83
Author: Marcus <[email protected]>
Date:   Wed Oct 9 21:17:19 2024 -0700

    remove github pages extension hosting

commit d614d0b
Author: Marcus <[email protected]>
Date:   Thu Oct 10 01:18:59 2024 -0700

    commit index files

commit cb46cba
Author: Marcus <[email protected]>
Date:   Wed Oct 9 21:26:03 2024 -0700

    update eslint globals

commit 66e93e2
Author: Marcus <[email protected]>
Date:   Mon Oct 7 18:47:49 2024 -0700

    remove unused patches

commit 396640f
Author: Marcus <[email protected]>
Date:   Mon Oct 7 18:13:04 2024 -0700

    remove direct eval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants