-
Notifications
You must be signed in to change notification settings - Fork 131
[XKit Preferences] Dark Mode Update #1848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
why not just always match the current tumblr colour scheme? |
Nobody knows what the user wants more than they do! I can't personally imagine why I would want a light Tumblr colour palette and a dark XKit theme, but I'm sure someone out there might prefer that setup. |
right, but this is using the tumblr palette to set the xkit palette in the first place, right? they should either be coupled properly or completely decoupled |
When opening the Control Panel or clicking the Match Tumblr Theme checkbox, it checks for whether the Tumblr colour palette is light or dark using When clicking the Enable Dark Mode checkbox, it simply sets dark mode. Match Tumblr Theme has priority over Enable Dark Mode, so it disables the checkbox (using CSS, so not a great disable tbqh) when it's on. I suppose I'm not really understanding why it needs to be one or the other :? |
ah, nevermind. i misunderstood your problem of dark mode being on by default. |
No problem! I think Match Tumblr Theme should be on by default, and Enable Dark Mode should be off by default, but I'm not sure how to set that in the javascript file ^__^; |
Continued in #2024 to keep up with current master. |
Put in some logic (using checkboxes) for the XKit Control Panel to:
I'm not sure exactly how to get the Dark Mode to not be on by default, and how to get Match Tumblr Theme to be on by default, unfortunately. Advice?
Updated some class styles with items that weren't previously defined and so defaulted to black (not very clear against a dark background), and also added more variables because white box-shadows are not really a great design choice in dark themes.
As a bonus, changed the default and kernel extension icons to SVGs for crispness and space!