Handle DLC uniquebodyparts in pose loading#994
Draft
niksirbi wants to merge 2 commits into
Draft
Conversation
Documents the silent data corruption bug when loading DLC files with uniquebodyparts, investigates whether the issue affects other source software (it does not), and proposes three solution options with a recommendation for the kwarg-based approach (Option 2). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
design/issue-977-uniquebodyparts.md) analysing the silent data corruption bug when loading DLC files withuniquebodyparts, and proposing solutionsdlc_csv_file_with_uniquebodyparts) that reproduces the bug with a minimal DLC-style CSVdesign/*.mdto check-manifest ignore list for now (we can decide to either git track such design docs, or delete them before merging)Note
This is a design-first PR, so no fix yet.
Following @sfmig's suggestion, we're experimenting with a new way of collectively using AI as a team, i.e. reviewing design docs co-authored by AI, before moving to actual implementation.
The design doc was generated by CLAUDE, so its claims should not be immediately taken at face value.
Please review the design doc and comment on the proposed approach before implementation begins.
Context
See #977.
When a DLC multi-animal project uses
uniquebodyparts, the output file has a ragged multi-index (not every individual has every bodypart). Ourfrom_dlc_style_dfdoes a blind reshape assuming a full rectangular grid, which silently corrupts data when the element counts happen to divide evenly (frame count halved, values scrambled across individuals/keypoints).The design doc covers: