Update bbox nan fixture#1020
Open
anna-teruel wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1020 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 41 41
Lines 2829 2829
=========================================
Hits 2829 2829 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
niksirbi
approved these changes
Jun 5, 2026
Member
niksirbi
left a comment
niksirbi
left a comment
There was a problem hiding this comment.
Thanks @anna-teruel!
Consider this your first approved PR to movement! I left an optional suggestion which you are free to take or leave as you prefer.
Co-authored-by: Niko Sirmpilatze <niko.sirbiladze@gmail.com>
for more information, see https://pre-commit.ci
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
The fixture
valid_bboxes_dataset_with_nancreates an unrealistic dataset forbbox, because it only introducesNaNto the position array, whileshapeandconfidenceremain valid. But as discussed in #1011, in bbox datasets, when a detection is missing it is represented byNaNvalues across all three arrays.What does this PR do?
Updates the
valid_bboxes_dataset_with_nanso that missing detections are represented inposition,shapeandconfidence.References
Related to #1011, this issue was identified while adding tests for
napari_layers_to_ds()in the draft-PR.How has this PR been tested?
Run all the tests locally with
pytestand everything passed.Is this a breaking change?
No. This just affects a text fixture.
Does this PR require an update to the documentation?
I don't think so.
Checklist: