Add utility function for video compression#149
Open
MKVarun wants to merge 5 commits into
Open
Conversation
Author
|
I've added a compress_video utility function to compress video files to apply SLEAP recommended setting. I've added tests for all the new functionality as well. I'm not sure if while testing I have to create a dummy video file on the fly and test for compression or whether that is standard testing practice. For now I mocked successful compression output. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 99.45% 99.49% +0.03%
==========================================
Files 8 9 +1
Lines 554 589 +35
==========================================
+ Hits 551 586 +35
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
This PR follows PR #145 to add video compression utility.
Why is this PR needed?
This PR addresses one of the feature requests in #67 and closes #10
What does this PR do?
This PR adds a utility function to compress videos using ffmpeg.
References
Issue #10 related to #67
How has this PR been tested?
The code has been tested locally with a sample video file and checked if it is compressing files.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
I've added docstrings in the function.
Checklist: