Skip to content

fix: fix agent extension params property to return a json object #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdavernas merged 3 commits into from
Dec 19, 2025
Merged

fix: fix agent extension params property to return a json object #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
964e275
fix: fix the agent extensions to return a json object
cdavernas Dec 19, 2025
aecb556
fix: bump solution version
cdavernas Dec 19, 2025
1446852
fix: fix unit tests
cdavernas Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/A2A.Client.Abstractions/A2A.Client.Abstractions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>A2A.Client</RootNamespace>
<VersionPrefix>0.14.0</VersionPrefix>
<VersionPrefix>0.15.0</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Client.Transports.Grpc/A2A.Client.Transports.Grpc.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>A2A.Client.Transports</RootNamespace>
<VersionPrefix>0.14.0</VersionPrefix>
<VersionPrefix>0.15.0</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Client.Transports.Http/A2A.Client.Transports.Http.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>A2A.Client.Transports</RootNamespace>
<VersionPrefix>0.14.0</VersionPrefix>
<VersionPrefix>0.15.0</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Client.Transports.JsonRpc/A2A.Client.Transports.JsonRpc.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>A2A.Client.Transports</RootNamespace>
<VersionPrefix>0.14.0</VersionPrefix>
<VersionPrefix>0.15.0</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Client/A2A.Client.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>A2A.Client</RootNamespace>
<VersionPrefix>0.14.0</VersionPrefix>
<VersionPrefix>0.15.0</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Core.JsonRpc/A2A.Core.JsonRpc.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>A2A</RootNamespace>
<VersionPrefix>0.14.0</VersionPrefix>
<VersionPrefix>0.15.0</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Core/A2A.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>A2A</RootNamespace>
<VersionPrefix>0.14.0</VersionPrefix>
<VersionPrefix>0.15.0</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Core/Models/AgentExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,6 @@ public sealed record AgentExtension
/// </summary>
[Description("Optional, extension-specific configuration parameters.")]
[DataMember(Order = 4, Name = "params"), JsonPropertyOrder(4), JsonPropertyName("params")]
public IDictionary<string, JsonNode>? Params { get; set; }
public JsonObject? Params { get; set; }

}
4 changes: 2 additions & 2 deletions src/A2A.Core/Services/AgentExtensionBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ public IAgentExtensionBuilder WithDescription(string description)
}

/// <inheritdoc/>
public IAgentExtensionBuilder WithParameters(IDictionary<string, JsonNode> parameters)
public IAgentExtensionBuilder WithParameters(IDictionary<string, JsonNode?> parameters)
{
ArgumentNullException.ThrowIfNull(parameters);
extension.Params = parameters;
extension.Params = new(parameters);
return this;
}

Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Core/Services/IAgentExtensionBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public interface IAgentExtensionBuilder
/// </summary>
/// <param name="parameters">An object representing the extension's configuration parameters.</param>
/// <returns>The builder instance.</returns>
IAgentExtensionBuilder WithParameters(IDictionary<string, JsonNode> parameters);
IAgentExtensionBuilder WithParameters(IDictionary<string, JsonNode?> parameters);

/// <summary>
/// Builds and returns the configured <see cref="AgentExtension"/>.
Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Server.Abstractions/A2A.Server.Abstractions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>A2A.Server</RootNamespace>
<VersionPrefix>0.14.0</VersionPrefix>
<VersionPrefix>0.15.0</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Server.AspNetCore/A2A.Server.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>A2A.Server</RootNamespace>
<VersionPrefix>0.14.0</VersionPrefix>
<VersionPrefix>0.15.0</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Server.Persistence.Memory/A2A.Server.Persistence.Memory.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>A2A.Server</RootNamespace>
<VersionPrefix>0.14.0</VersionPrefix>
<VersionPrefix>0.15.0</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Server.Persistence.Redis/A2A.Server.Persistence.Redis.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>A2A.Server</RootNamespace>
<VersionPrefix>0.14.0</VersionPrefix>
<VersionPrefix>0.15.0</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Server.Scheduling.Memory/A2A.Server.Scheduling.Memory.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>A2A.Server</RootNamespace>
<VersionPrefix>0.14.0</VersionPrefix>
<VersionPrefix>0.15.0</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Server.Scheduling.Quartz/A2A.Server.Scheduling.Quartz.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>A2A.Server</RootNamespace>
<VersionPrefix>0.14.0</VersionPrefix>
<VersionPrefix>0.15.0</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Server.Transports.Grpc/A2A.Server.Transports.Grpc.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>A2A.Server.Transports</RootNamespace>
<VersionPrefix>0.14.0</VersionPrefix>
<VersionPrefix>0.15.0</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Server.Transports.Http/A2A.Server.Transports.Http.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>A2A.Server.Transports</RootNamespace>
<VersionPrefix>0.14.0</VersionPrefix>
<VersionPrefix>0.15.0</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion src/A2A.Server.Transports.JsonRpc/A2A.Server.Transports.JsonRpc.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>A2A.Server.Transports</RootNamespace>
<VersionPrefix>0.14.0</VersionPrefix>
<VersionPrefix>0.15.0</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion tests/A2A.UnitTests/Services/AgentExtensionFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ internal static class AgentExtensionFactory
Uri = new Uri("https://example.com/agent-extension"),
Description = "Sample Agent Extension",
Required = true,
Params = new Dictionary<string, JsonNode>
Params = new()
{
["param1"] = "value1",
["param2"] = 42
Expand Down