Skip to content

[MNT] - Update Welch implementation - #358

Merged
TomDonoghue merged 5 commits into
mainfrom
welch
Oct 27, 2025
Merged

[MNT] - Update Welch implementation#358
TomDonoghue merged 5 commits into
mainfrom
welch

Conversation

@TomDonoghue

@TomDonoghue TomDonoghue commented Oct 27, 2025

Copy link
Copy Markdown
Member

Responds to #357 (and related to #344). See #357 for notes and checks of the new implementation.

Updates:

  • update the implementation of compute_spectrum_welch to use scipy.signal.welch
  • remove our window padding options, as this is now available through scipy.signal.welch
  • update the checker function, including updating the name (this is not public facing so I don't think should be an issue), and updating for the checker function to support the fast_len input
  • removes the outliers_percent option from compute_spectrum_welch, as this is no longer supported using this implementation

@ryanhammonds ryanhammonds left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@TomDonoghue
TomDonoghue merged commit 50f3e5a into main Oct 27, 2025
10 checks passed
@TomDonoghue
TomDonoghue deleted the welch branch October 27, 2025 20:51
@neurodsp-tools neurodsp-tools deleted a comment from codecov Bot Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants