[ENH] - Add signal yielder functionality - #356
Merged
Merged
Conversation
ryanhammonds
approved these changes
Oct 28, 2025
ryanhammonds
left a comment
Member
There was a problem hiding this comment.
Looks good! The I see the usefulness of step_over_time. I'm unsure the use case for:
for sig in step_over_signals(signals):
passThis seems more verbose than calling:
for sig in signals:
passMaybe the generator is useful for other cases:
gen = (sig for sig in signals)
next(gen)
gen = step_over_signals(signals)
next(gen)
Anyways this looks good to me!
Member
Author
|
Thanks for checking @ryanhammonds! I agree the time stepper is more useful, I added the channel stepper somewhat for completeness. The use case I was thinking of like the last version you noted - creating a generator at some point, and calling next as needed (I've been doing things like this in the use case that I've been using these in, which is making some gifs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add some helper / utility functions for iterating across arrays. With long time series, in some cases it can be useful to iterate across segments. It adds a function to step across time (for a 1D or 2D array) and a separate function for stepping across 'channels' (across rows within a 2D array).