Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new reference to the Prompt2Model readme #399

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Add new reference to the Prompt2Model readme #399

merged 3 commits into from
Apr 23, 2024

Conversation

viswavi
Copy link
Collaborator

@viswavi viswavi commented Apr 23, 2024

Description

Adding a new paper to the Prompt2Model references to cite.

References

N/A

Blocked by

N/A

@viswavi viswavi requested a review from neubig April 23, 2024 02:01
Copy link
Collaborator

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to make it a little more clear what each of these papers explain. For instance:

If you'd like to discuss the overall prompt2model framework, please reference
XXX

If you'd like to discuss the dataset transformation functionality, please reference
YYY

@viswavi
Copy link
Collaborator Author

viswavi commented Apr 23, 2024

@neubig done!

@viswavi viswavi requested a review from neubig April 23, 2024 14:17
@neubig
Copy link
Collaborator

neubig commented Apr 23, 2024

Looks good, I approve but linting is failing!

@viswavi viswavi merged commit 19b541b into main Apr 23, 2024
8 checks passed
@viswavi viswavi deleted the viswavi-patch-1 branch April 23, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants